[GitHub] [calcite] amaliujia commented on a change in pull request #1568: [CALCITE-3486]MysqlSqlDialect unparse ROW keyword does not exist

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #1568: [CALCITE-3486]MysqlSqlDialect unparse ROW keyword does not exist
URL: https://github.com/apache/calcite/pull/1568#discussion_r344279806
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
 ##########
 @@ -3699,6 +3700,14 @@ void checkPeriodPredicate(Checker checker) {
         .ok(expected);
   }
 
+  @Test public void testInsertDialect() {
+    // See [CALCITE-3486] MysqlSqlDialect unparse ROW keyword does not exist
 
 Review comment:
   You don't need this comment. If you actually want to see this test is testing `ROW`, you can rename this test as `testInsertWithRowDialect`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services