You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/12 00:41:20 UTC

[GitHub] [tvm] vegaluisjose opened a new pull request #7098: [CI][BYORTL] add Verilator regression test to CI

vegaluisjose opened a new pull request #7098:
URL: https://github.com/apache/tvm/pull/7098


   @tqchen @tmoreau89 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-743926866


   Thanks @vegaluisjose , looking at the files, looks like that `libverilator.so` needs to be shared cross stages. Merging this now would create a problem.
   
   It would be great to not do so, and build the library before test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 commented on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-766175904


   Thank you @liangfu @tqchen @vegaluisjose ; the PR has been merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen edited a comment on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-744129790






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vegaluisjose commented on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-743928550


   Hey @tqchen ,
   
   I don't think I am following, could you elaborate on what the problem will be?
   
   The library is currently [built](https://github.com/apache/tvm/blob/main/cmake/modules/contrib/Verilator.cmake#L19) when the CMAKE macro `USE_VERILATOR_HW` is `ON`. Also, during this stage the library is [linked](https://github.com/apache/tvm/blob/main/cmake/modules/contrib/Verilator.cmake#L23-L24), so tvm knows where to find such library when selecting that backend in Python.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-744129790


   The main problem would be right after we merge the PR，if there is no library named libverilator(because it is not yet in the rules) the CI on the main will fail. Until we add a PR to build the libverilator hw, given that the hw itself is not hard to build, would be great if we build it at the test stage instead of caching it after build 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] liangfu commented on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
liangfu commented on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-751157820


   > It would really be nice if the hw part can be built independently, and loaded on demand.
   
   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen edited a comment on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-743926866


   Thanks @vegaluisjose , looking at the files, looks like that `libverilator.so` needs to be shared cross stages. Merging this now would create a problem.
   
   It would be great to not do so, and build the library before test (at the same stage)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vegaluisjose commented on pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on pull request #7098:
URL: https://github.com/apache/tvm/pull/7098#issuecomment-766111073


   Hey guys,
   
   The CI is updated now with the new version of Verilator backend. CI (Jenkins) seems to be working.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 merged pull request #7098: [CI][BYORTL] add Verilator regression test to CI

Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7098:
URL: https://github.com/apache/tvm/pull/7098


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org