You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2011/02/01 00:09:28 UTC

[jira] Created: (WHIRR-226) Add the ability to destroy a specific or a random cluster instance

Add the ability to destroy a specific or a random cluster instance
------------------------------------------------------------------

                 Key: WHIRR-226
                 URL: https://issues.apache.org/jira/browse/WHIRR-226
             Project: Whirr
          Issue Type: New Feature
          Components: cli, core
            Reporter: Andrei Savu
            Assignee: Andrei Savu
             Fix For: 0.4.0


For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WHIRR-226) Add the ability to destroy a specific or a random cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989352#comment-12989352 ] 

Andrei Savu commented on WHIRR-226:
-----------------------------------

> Do you need to expose the 'random' feature in the CLI?

Not really. It makes sense for services like ZooKeeper but for services like HDFS killing the namenode will bring down the whole cluster so it's not that useful. I now realize that it needs to be aware of the instance role.

I will submit an updated version of the patch soon (+ unit tests).


> Add the ability to destroy a specific or a random cluster instance
> ------------------------------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-226) Add the ability to destroy a specific or a random cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-226:
------------------------------

    Attachment: WHIRR-226.patch

I have updated the patch and added basic unit tests. 

> Add the ability to destroy a specific or a random cluster instance
> ------------------------------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WHIRR-226) Add the ability to destroy a cluster instance

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991580#comment-12991580 ] 

Tom White commented on WHIRR-226:
---------------------------------

+1

> Add the ability to destroy a cluster instance
> ---------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-226) Add the ability to destroy a specific or a random cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-226:
------------------------------

    Attachment: WHIRR-226.patch

Let me know what you think. 

> Add the ability to destroy a specific or a random cluster instance
> ------------------------------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WHIRR-226) Add the ability to destroy a specific or a random cluster instance

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988973#comment-12988973 ] 

Tom White commented on WHIRR-226:
---------------------------------

Do you need to expose the 'random' feature in the CLI? Can the test not choose this itself?

Please add a unit test for DestroyInstanceCommand.


> Add the ability to destroy a specific or a random cluster instance
> ------------------------------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-226) Add the ability to destroy a cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-226:
------------------------------

    Attachment: WHIRR-226.patch

I have updated the patch. Tom, thanks for reviewing. 

> Add the ability to destroy a cluster instance
> ---------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-226) Add the ability to destroy a cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-226:
------------------------------

    Status: Patch Available  (was: Open)

> Add the ability to destroy a cluster instance
> ---------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-226) Add the ability to destroy a cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-226:
------------------------------

    Summary: Add the ability to destroy a cluster instance  (was: Add the ability to destroy a specific or a random cluster instance)

> Add the ability to destroy a cluster instance
> ---------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WHIRR-226) Add the ability to destroy a cluster instance

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-226:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've just committed this. Thanks Tom. 

> Add the ability to destroy a cluster instance
> ---------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WHIRR-226) Add the ability to destroy a cluster instance

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989517#comment-12989517 ] 

Tom White commented on WHIRR-226:
---------------------------------

Looks good. Thanks for adding the test. Looks like there are some spurious imports in DestroyInstanceCommand - e.g. Random. And some imports re-arranged in Service that don't need to be.

> Add the ability to destroy a cluster instance
> ---------------------------------------------
>
>                 Key: WHIRR-226
>                 URL: https://issues.apache.org/jira/browse/WHIRR-226
>             Project: Whirr
>          Issue Type: New Feature
>          Components: cli, core
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-226.patch, WHIRR-226.patch
>
>
> For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira