You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/08 14:01:32 UTC

[GitHub] [shardingsphere] lwtdev commented on a change in pull request #8077: Fix parse problem in delete multi table statement and select into sta…

lwtdev commented on a change in pull request #8077:
URL: https://github.com/apache/shardingsphere/pull/8077#discussion_r519407755



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DMLStatement.g4
##########
@@ -105,11 +105,11 @@ singleTableClause
     ;
 
 multipleTablesClause
-    : tableAliasRefList FROM tableReferences | FROM tableAliasRefList USING tableReferences
+    : multipleTableNames FROM tableReferences | FROM multipleTableNames USING tableReferences
     ;
 
 multipleTableNames
-    : tableName DOT_ASTERISK_? (COMMA_ tableName DOT_ASTERISK_?)*
+    : tableIdentOptWild (COMMA_ tableIdentOptWild)*
     ;

Review comment:
       @jingshanglu  Thanks very much for you advice. I will change it. 
   What about `tableLockingList` that references ` tableAliasRefList`. Could I remove it , too? It's unused , but I don't know why this was added.
   ```
   tableLockingList
       : OF tableAliasRefList
       ;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org