[GitHub] [arrow] nealrichardson commented on pull request #8365: ARROW-6582: [R] Arrow to R fails with embedded nuls in strings

[GitBox <gi...@apache.org>]

nealrichardson commented on pull request #8365:
URL: https://github.com/apache/arrow/pull/8365#issuecomment-752264998


   It would be good to get this resolved for 3.0. I pushed a naive fix: if `arrow.skip_nul = TRUE` (default FALSE, per base::readLines and base::scan), we go through a slow path and strip out nuls. A better solution (1) would check `arrow.skip_nul` outside of the loop (I could do this now but figure there's a smarter C/C++ way than I would have come up with); (2) would probably try the fast conversion path anyway and catch the exception and retry with the slow path, so even if arrow.skip_nul == true, we only do the slow path if there is a nul (I tried try/catch but didn't get it working right); and (3) it should raise a warning when it does strip a nul, as I believe readLines and scan do.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org