You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/06 03:04:37 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #13075: KAFKA-9087 Replace log high watermark by future log high watermark wh…

ijuma commented on code in PR #13075:
URL: https://github.com/apache/kafka/pull/13075#discussion_r1063058965


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -205,6 +205,61 @@ class ReplicaManagerTest {
     when(cache.getAliveBrokerNodes(any[ListenerName])).thenReturn(aliveBrokers)
   }
 
+  @Test
+  def testMaybeAddLogDirFetchersForV1MessageFormat(): Unit = {

Review Comment:
   V1 is deprecated and we intend to remove it (along with V0). We should not be writing new tests with that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org