[GitHub] [spark] wangyum commented on a diff in pull request #42760: [SPARK-45041][SQL] Using --proxy-user would get GSS init failed when `hive.metastore.token.signature` not empty

["wangyum (via GitHub)" <gi...@apache.org>]

wangyum commented on code in PR #42760:
URL: https://github.com/apache/spark/pull/42760#discussion_r1319669922


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/security/HiveDelegationTokenProvider.scala:
##########
@@ -41,6 +41,8 @@ import org.apache.spark.util.Utils
 private[spark] class HiveDelegationTokenProvider
     extends HadoopDelegationTokenProvider with Logging {
 
+  private val tokenSignature = "spark.delegation.token";

Review Comment:
   Did i miss something?
   ```
   $ bin/spark-sql --proxy-user proxy_user                
   Exception in thread "main" org.apache.spark.SparkException: Only one of --proxy-user or --principal can be provided.
   	at org.apache.spark.deploy.SparkSubmitArguments.error(SparkSubmitArguments.scala:671)
   	at org.apache.spark.deploy.SparkSubmitArguments.validateSubmitArguments(SparkSubmitArguments.scala:288)
   	at org.apache.spark.deploy.SparkSubmitArguments.validateArguments(SparkSubmitArguments.scala:246)
   	at org.apache.spark.deploy.SparkSubmitArguments.<init>(SparkSubmitArguments.scala:125)
   	at org.apache.spark.deploy.SparkSubmit$$anon$2$$anon$3.<init>(SparkSubmit.scala:1070)
   	at org.apache.spark.deploy.SparkSubmit$$anon$2.parseArguments(SparkSubmit.scala:1070)
   	at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:85)
   	at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:1087)
   	at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:1096)
   	at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org