You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Eric Pugh (Jira)" <ji...@apache.org> on 2022/12/29 12:59:00 UTC
[jira] [Commented] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652832#comment-17652832 ]
Eric Pugh commented on SOLR-10465:
----------------------------------
So [~gerlowskija][~dsmiley] I think I'm going to need some guidance... Do we need a online design session to figure out what to do? It seems like our SolrClient is working at cross purposes... Is it a generic client that can interact with any collection, and therefore you pass in collection name, or is it tied to a single collection? Or is it even a generic client to work with all end points of Solr?
I'm honestly not really sure either way... And if you generalize a SolrClient to doing more then just inserting docs and making queries, but to doing other operations against solr, like admin apis calls, or the functions, then maybe having the default collection makes even less sense? SolrClientV2.java ????
> setIdField should be deprecated in favor of SolrClientBuilder methods
> ---------------------------------------------------------------------
>
> Key: SOLR-10465
> URL: https://issues.apache.org/jira/browse/SOLR-10465
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: 7.0
>
> Attachments: SOLR-10465.patch, SOLR-10465.patch
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setIdField}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org