[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation
URL: https://github.com/apache/helix/pull/367#discussion_r308992497
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java
 ##########
 @@ -121,19 +125,24 @@ protected JsonNode getJsonObject(HttpResponse httpResponse) throws IOException {
   }
 
   @VisibleForTesting
-  protected HttpResponse post(String url, Map<String, String> payloads) throws IOException {
+  protected synchronized HttpResponse post(String url, Map<String, String> payloads) throws IOException {
 
 Review comment:
   You will have problem with locking on this method. It even can blocks per node querying. I think we should lock inside get per partition data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services