You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/20 04:50:05 UTC

[GitHub] [shardingsphere] dongzl opened a new pull request, #22285: [WIP] add `HintValueContext` for optimize hint.

dongzl opened a new pull request, #22285:
URL: https://github.com/apache/shardingsphere/pull/22285

   For #20736 .
   
   Changes proposed in this pull request:
     - add `HintValueContext` for optimize hint.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #22285: [WIP] add `HintValueContext` for optimize hint.

Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on code in PR #22285:
URL: https://github.com/apache/shardingsphere/pull/22285#discussion_r1029953045


##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/QueryContext.java:
##########
@@ -38,10 +40,23 @@ public final class QueryContext {
     
     private String sqlStatementDatabaseName;
     
+    private HintValueContext hintValueContext;
+    
     public QueryContext(final SQLStatementContext<?> sqlStatementContext, final String sql, final List<Object> params) {
         this.sqlStatementContext = sqlStatementContext;
         this.sql = sql;
         parameters = params;
+        this.hintValueContext = SQLHintUtils.extractHint(sql);

Review Comment:
   For this kind of untransferred, should we just not extract it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on pull request #22285: add `HintValueContext` for optimize hint.

Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on PR #22285:
URL: https://github.com/apache/shardingsphere/pull/22285#issuecomment-1328494913

   @strongduanmu Please have a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #22285: [WIP] add `HintValueContext` for optimize hint.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22285:
URL: https://github.com/apache/shardingsphere/pull/22285#issuecomment-1323677563

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22285?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22285](https://codecov.io/gh/apache/shardingsphere/pull/22285?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b72c15) into [master](https://codecov.io/gh/apache/shardingsphere/commit/69792f7656f657b495c5ea288b1ea7930d517ba5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (69792f7) will **decrease** coverage by `0.03%`.
   > The diff coverage is `37.68%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #22285      +/-   ##
   ============================================
   - Coverage     51.00%   50.97%   -0.04%     
     Complexity     2508     2508              
   ============================================
     Files          4164     4165       +1     
     Lines         57830    57877      +47     
     Branches       9819     9835      +16     
   ============================================
   + Hits          29499    29502       +3     
   - Misses        25787    25829      +42     
   - Partials       2544     2546       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22285?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/type/standard/ShardingStandardRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvc3RhbmRhcmQvU2hhcmRpbmdTdGFuZGFyZFJvdXRpbmdFbmdpbmUuamF2YQ==) | `78.44% <ø> (ø)` | |
   | [...ddl/impl/ShardingAlterIndexStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0FsdGVySW5kZXhTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `75.00% <ø> (ø)` | |
   | [...ddl/impl/ShardingAlterTableStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0FsdGVyVGFibGVTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `69.23% <ø> (ø)` | |
   | [.../ddl/impl/ShardingAlterViewStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0FsdGVyVmlld1N0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `78.94% <ø> (ø)` | |
   | [...impl/ShardingCreateFunctionStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0NyZWF0ZUZ1bmN0aW9uU3RhdGVtZW50VmFsaWRhdG9yLmphdmE=) | `78.57% <ø> (ø)` | |
   | [...dl/impl/ShardingCreateIndexStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0NyZWF0ZUluZGV4U3RhdGVtZW50VmFsaWRhdG9yLmphdmE=) | `76.92% <ø> (ø)` | |
   | [...mpl/ShardingCreateProcedureStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0NyZWF0ZVByb2NlZHVyZVN0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `80.00% <ø> (ø)` | |
   | [...dl/impl/ShardingCreateTableStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0NyZWF0ZVRhYmxlU3RhdGVtZW50VmFsaWRhdG9yLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...ddl/impl/ShardingCreateViewStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0NyZWF0ZVZpZXdTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `71.79% <ø> (ø)` | |
   | [.../ddl/impl/ShardingDropIndexStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0Ryb3BJbmRleFN0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `85.71% <ø> (ø)` | |
   | ... and [20 more](https://codecov.io/gh/apache/shardingsphere/pull/22285/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #22285: add `HintValueContext` for optimize hint.

Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22285:
URL: https://github.com/apache/shardingsphere/pull/22285


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org