[GitHub] [spark] xkrogen commented on a change in pull request #29874: [SPARK-32998] Add ability to override default remote repos with inter…

[GitBox <gi...@apache.org>]

xkrogen commented on a change in pull request #29874:
URL: https://github.com/apache/spark/pull/29874#discussion_r495202070



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2511,7 +2511,8 @@ object SQLConf {
       .version("3.0.0")
       .stringConf
       .createWithDefault(
-        "https://maven-central.storage-download.googleapis.com/maven2/")
+        sys.env.getOrElse(
+          "INTERNAL_ARTIFACTORY", "https://maven-central.storage-download.googleapis.com/maven2/"))

Review comment:
       I don't think it makes sense to use the environment variable here. This is already configurable and just set as a fallback. If anything, the code in `IsolatedClientLoader` could be updated to leverage the environment variable since, as mentioned in the config doc, Maven Central will still be tried first even if this is configured to be something else.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org