You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/09/26 18:21:16 UTC
Review Request 52267: GEODE-1937: Making precheckin depend on running
examples
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52267/
-----------------------------------------------------------
Review request for geode and William Markito.
Repository: geode
Description
-------
Making precheckin depend on running examples
Also Setting a default GEODE_HOME to use when running example tests. Fixing
the example tests scripts to indicate that that are bash scripts as the
first line in the header.
Diffs
-----
build.gradle f7ce6bc49b87f15fa5b06d76fe4c24376c532933
geode-examples/build.gradle 1eadc3197c5345f90ca0d6f12e0c1f6594cbb68d
geode-examples/replicated/scripts/pidkiller.sh 1a3eaf24a83da0692ca407383e0af4d3c57578a8
geode-examples/replicated/scripts/setEnv.sh 60befc6bfe564fd5abfb1c47038ed1afeae74dac
geode-examples/replicated/scripts/startAll.sh f4ce413a27dd1ad136b364dfcfbe35a52c554ee9
geode-examples/replicated/scripts/stopAll.sh 2a2c39b48ec469d8347529d3d471d49b34f29855
Diff: https://reviews.apache.org/r/52267/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 52267: GEODE-1937: Making precheckin depend on
running examples
Posted by William Markito <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52267/#review150469
-----------------------------------------------------------
Ship it!
Ship It!
- William Markito
On Sept. 26, 2016, 9:29 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52267/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 9:29 p.m.)
>
>
> Review request for geode and William Markito.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Making precheckin depend on running examples
>
> Also Setting a default GEODE_HOME to use when running example tests. Fixing
> the example tests scripts to indicate that that are bash scripts as the
> first line in the header.
>
>
> Diffs
> -----
>
> build.gradle f7ce6bc49b87f15fa5b06d76fe4c24376c532933
> geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
> geode-examples/build.gradle 1eadc3197c5345f90ca0d6f12e0c1f6594cbb68d
> geode-examples/replicated/scripts/pidkiller.sh 1a3eaf24a83da0692ca407383e0af4d3c57578a8
> geode-examples/replicated/scripts/setEnv.sh 60befc6bfe564fd5abfb1c47038ed1afeae74dac
> geode-examples/replicated/scripts/startAll.sh f4ce413a27dd1ad136b364dfcfbe35a52c554ee9
> geode-examples/replicated/scripts/stopAll.sh 2a2c39b48ec469d8347529d3d471d49b34f29855
>
> Diff: https://reviews.apache.org/r/52267/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 52267: GEODE-1937: Making precheckin depend on
running examples
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52267/
-----------------------------------------------------------
(Updated Sept. 26, 2016, 9:29 p.m.)
Review request for geode and William Markito.
Changes
-------
Moving precheckin dependency to geode-assembly; the precheckin target doesn't exist for the root project.
Repository: geode
Description
-------
Making precheckin depend on running examples
Also Setting a default GEODE_HOME to use when running example tests. Fixing
the example tests scripts to indicate that that are bash scripts as the
first line in the header.
Diffs (updated)
-----
build.gradle f7ce6bc49b87f15fa5b06d76fe4c24376c532933
geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
geode-examples/build.gradle 1eadc3197c5345f90ca0d6f12e0c1f6594cbb68d
geode-examples/replicated/scripts/pidkiller.sh 1a3eaf24a83da0692ca407383e0af4d3c57578a8
geode-examples/replicated/scripts/setEnv.sh 60befc6bfe564fd5abfb1c47038ed1afeae74dac
geode-examples/replicated/scripts/startAll.sh f4ce413a27dd1ad136b364dfcfbe35a52c554ee9
geode-examples/replicated/scripts/stopAll.sh 2a2c39b48ec469d8347529d3d471d49b34f29855
Diff: https://reviews.apache.org/r/52267/diff/
Testing
-------
Thanks,
Dan Smith