You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2023/03/15 10:00:23 UTC
[GitHub] [ozone] ashishkumar50 opened a new pull request, #4404: HDDS-8099. Make unlimited length the default in ozone debug ldb.
ashishkumar50 opened a new pull request, #4404:
URL: https://github.com/apache/ozone/pull/4404
## What changes were proposed in this pull request?
Make unlimited(-1) length the default in ozone debug ldb.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8099
## How was this patch tested?
Built locally and verified using docker-compose by creating more than 100 keys and run ldb command to see if it returns all data by default without giving "-l -1" option while running command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] arp7 merged pull request #4404: HDDS-8099. Make unlimited length the default in ozone debug ldb.
Posted by "arp7 (via GitHub)" <gi...@apache.org>.
arp7 merged PR #4404:
URL: https://github.com/apache/ozone/pull/4404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on a diff in pull request #4404: HDDS-8099. Make unlimited length the default in ozone debug ldb.
Posted by "neils-dev (via GitHub)" <gi...@apache.org>.
neils-dev commented on code in PR #4404:
URL: https://github.com/apache/ozone/pull/4404#discussion_r1138085578
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestLDBCli.java:
##########
@@ -253,6 +254,7 @@ public void testDNDBSchemaV3() throws Exception {
DBScanner.setWithKey(true);
// Scan all container
+ DBScanner.setLimit(-1);
Review Comment:
Thanks @ashishkumar50 for this improvement to the ldb tool. Suggestion, increase the number of containers in the blocktable for testing `schemaV3`:
Test would improve for testing unlimited and limit 2 table scans by increasing the number of containers placed in the `blockTable`. Testing the limit with` setLimit(-1)` then testing the _constrained_ limit for` setLimit(2)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org