[GitHub] JEBailey commented on a change in pull request #1: Sling 3270

[GitBox <gi...@apache.org>]

JEBailey commented on a change in pull request #1: Sling 3270
URL: https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r246518430
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -37,25 +37,36 @@
 
     <properties>
         <sling.java.version>8</sling.java.version>
-        <org.ops4j.pax.exam.version>4.11.0</org.ops4j.pax.exam.version>
+        <org.ops4j.pax.exam.version>4.12.0</org.ops4j.pax.exam.version>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.resources.sourceEncoding>UTF-8</project.resources.sourceEncoding>
     </properties>
 
     <scm>
         <connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</connection>
         <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</developerConnection>
         <url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git</url>
-      <tag>HEAD</tag>
-  </scm>
+        <tag>HEAD</tag>
+    </scm>
 
     <build>
         <plugins>
             <plugin>
-                <groupId>biz.aQute.bnd</groupId>
-                <artifactId>bnd-maven-plugin</artifactId>
 
 Review comment:
   @rombert Some additional details on this. This bundle was using maven-bundle-plugin up until the prior release when there a desire to install a pax exam test and it was discovered there was a problem with the pax exam.  see https://issues.apache.org/jira/browse/SLING-7351. This particular bundle had a more complex solution then the one detailed in the link, with a bnd.bnd file specified and a change to bnd-maven-plugin. The maven-bundle-plugin provides a far better experience from a build perspective with a more detailed generation of a baseline report and with less configuration. So I took the suggested comment in that JIRA and updated this code accordingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services