[jira] [Commented] (NIFI-5349) DB Fetch processors do not support Expression Language for Initial Max Value

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526681#comment-16526681 ] 

ASF GitHub Bot commented on NIFI-5349:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2822

    NIFI-5349: Fixed EL handling in Initial Max Value props for DB Fetch processors

    Also updated documentation to reflect the intended (and actual) behavior.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5349

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2822.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2822
    
----
commit 3a8e4cc89ae28c2641f459222de74fdf798d4dba
Author: Matthew Burgess <ma...@...>
Date:   2018-06-28T19:02:58Z

    NIFI-5349: Fixed EL handling in Initial Max Value props for DB Fetch processors

----


> DB Fetch processors do not support Expression Language for Initial Max Value
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-5349
>                 URL: https://issues.apache.org/jira/browse/NIFI-5349
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> As part of NIFI-2881, support for expression language was introduced for many/most fields in the DB Fetch processors (GenerateTableFetch, QueryDatabaseTable). However for the Initial Max Value properties (user-defined properties of the form initial.maxvalue.<column>), the documentation is inconsistent as to whether it supports EL, and if EL is present it is not evaluated.
> The DB Fetch processors should be updated to fully support (and correctly document) the Initial Max Value capability. Note that the scope of EL evaluation may differ between GenerateTableFetch and QueryDatabaseTable, as the former accepts incoming flow files (via NIFI-2881) but the latter does not.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)