You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/19 00:20:05 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3095: ESP32: Allow a BSS section to reside in external memory

yamt commented on a change in pull request #3095:
URL: https://github.com/apache/incubator-nuttx/pull/3095#discussion_r597325178



##########
File path: arch/xtensa/src/common/xtensa_attr.h
##########
@@ -63,4 +69,10 @@
 
 #define RTC_RODATA_ATTR __attribute__((section(".rtc.rodata")))
 
+/* Forces bss variable into external memory. */

Review comment:
       what kind of data needs to be forced to be in spiram?
   
   if its purpose is to save internal memory, i guess it's more useful to make it "allow to be in spiram", rather than force. ie. make `EXT_RAM_ATTR` no-op unless `CONFIG_XTENSA_EXTMEM_BSS` is enabled.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org