You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bjornjon <gi...@git.apache.org> on 2016/03/11 04:53:19 UTC
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
GitHub user bjornjon opened a pull request:
https://github.com/apache/spark/pull/11644
[SPARK-13810] [CORE] Add Port Configuration Suggestions on Bind Exceptions
## What changes were proposed in this pull request?
Currently, when a java.net.BindException is thrown, it displays the following message, irrespective of the port being used:
java.net.BindException: Address already in use: Service '$serviceName' failed after 16 retries!
The changes here add port configuration suggestions for spark.ui.port, spark.driver.port and spark.blockManager.port. For example, if the Spark UI exceeds spark.port.maxRetries, users will see:
java.net.BindException: Address already in use: Service 'SparkUI' failed after 16 retries! Consider setting spark.ui.port to an available port or increasing spark.port.maxRetries.
## How was this patch tested?
Manual tests for SparkUI, sparkDriver and NettyBlockTransferService port bind exceptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjornjon/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11644
----
commit d815d8a9f7b97921fa93e9c35c114275bae715b3
Author: Bjorn Jonsson <bj...@gmail.com>
Date: 2016-03-11T02:06:23Z
Optional Parameter to Allow Port Configuration Suggestions on Bind Collision
commit 8993cec1e895762ba8f991bff8c5037949457945
Author: Bjorn Jonsson <bj...@gmail.com>
Date: 2016-03-11T02:19:43Z
Bind Collision Error Message for spark.ui.port
commit ecddc9d8ba6a57665b29073712ae0b90c82ab5f7
Author: Bjorn Jonsson <bj...@gmail.com>
Date: 2016-03-11T02:23:51Z
Bind Collision Error Message for spark.blockManager.port
commit ca140d417e36b991caf8afb7b43ede406810c27a
Author: Bjorn Jonsson <bj...@gmail.com>
Date: 2016-03-11T02:40:29Z
Bind Collision Error Message for spark.driver.port
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195655145
**[Test build #52980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52980/consoleFull)** for PR 11644 at commit [`3a0e3f1`](https://github.com/apache/spark/commit/3a0e3f1fc08966c1d07f78e0a478330e5a8df86a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195429708
I can't see the earlier version of this diff, but I dont' understand why you'd need to introduce a `SparkEnv`. I see that currently, when a `WebUI` is created, you no longer know which conf was responsible for choosing the port. But that seems easy to fix -- couldn't the constructor just also take a `portConf: Option[String]`?
In any case, this is a strict improvement as-is -- if that adds too much complexity to get the correct conf name in there or something, its fine w/ me to add this as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/11644#discussion_r55849588
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2014,8 +2014,10 @@ private[spark] object Utils extends Logging {
} catch {
case e: Exception if isBindCollision(e) =>
if (offset >= maxRetries) {
- val exceptionMessage =
- s"${e.getMessage}: Service$serviceString failed after $maxRetries retries!"
+ val exceptionMessage = s"${e.getMessage}: Service$serviceString failed after " +
+ s"$maxRetries retries! Consider explicitly setting the appropriate port for" +
+ s"$serviceString (for example spark.ui.port for SparkUI) to an available port " +
+ "or increasing spark.port.maxRetries."
--- End diff --
worth also mentioning that choosing a port of `0` has the magic property of finding an open port?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195451612
bjorn and I chatted about this a bit more offline, I understand why its a bit complicated for the non-UI port a bit more, but also feel this simple change is good enough to solve most of the concern, so LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195604878
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195549744
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195604349
**[Test build #52948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52948/consoleFull)** for PR 11644 at commit [`8177e69`](https://github.com/apache/spark/commit/8177e691540bdc583d3095b0463d4123482d2096).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195620580
**[Test build #52975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52975/consoleFull)** for PR 11644 at commit [`933e205`](https://github.com/apache/spark/commit/933e205a8905864a66c2c6724bf2c9d1f27d9c28).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11644#discussion_r55905764
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2014,8 +2014,10 @@ private[spark] object Utils extends Logging {
} catch {
case e: Exception if isBindCollision(e) =>
if (offset >= maxRetries) {
- val exceptionMessage =
- s"${e.getMessage}: Service$serviceString failed after $maxRetries retries!"
+ val exceptionMessage = s"${e.getMessage}: Service$serviceString failed after " +
+ s"$maxRetries retries! Consider explicitly setting the appropriate port for" +
--- End diff --
need space here after for
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195655516
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52980/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195655515
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195650306
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195650234
**[Test build #52976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52976/consoleFull)** for PR 11644 at commit [`0d8303e`](https://github.com/apache/spark/commit/0d8303e2e43ecd280035a26547876278f5709ebe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195620583
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52975/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195628886
**[Test build #52980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52980/consoleFull)** for PR 11644 at commit [`3a0e3f1`](https://github.com/apache/spark/commit/3a0e3f1fc08966c1d07f78e0a478330e5a8df86a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195622365
**[Test build #52976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52976/consoleFull)** for PR 11644 at commit [`0d8303e`](https://github.com/apache/spark/commit/0d8303e2e43ecd280035a26547876278f5709ebe).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195342004
LGTM. (By the way Bjorn fields a lot of support issues for Spark and this is apparently a frequent source of questions/confusion. Great if a simple message change can preempt a number of questions.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195650307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52976/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195928608
Merged to master and 1.6. I added 1.6 since it's just a tiny doc improvement, and probably adds disproportionate value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195620424
**[Test build #52975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52975/consoleFull)** for PR 11644 at commit [`933e205`](https://github.com/apache/spark/commit/933e205a8905864a66c2c6724bf2c9d1f27d9c28).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by bjornjon <gi...@git.apache.org>.
Github user bjornjon commented on a diff in the pull request:
https://github.com/apache/spark/pull/11644#discussion_r55908378
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2014,8 +2014,10 @@ private[spark] object Utils extends Logging {
} catch {
case e: Exception if isBindCollision(e) =>
if (offset >= maxRetries) {
- val exceptionMessage =
- s"${e.getMessage}: Service$serviceString failed after $maxRetries retries!"
+ val exceptionMessage = s"${e.getMessage}: Service$serviceString failed after " +
+ s"$maxRetries retries! Consider explicitly setting the appropriate port for" +
--- End diff --
There is a space in $serviceString, as before, so the text is exactly as shown in the description above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195604555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52948/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195248388
I like the principle, but passing around an error message as an arg to `SparkEnv` makes this tiny aspect leak too much into the API. If it's just to be able to report which config to change, I think I wouldn't do that. Generically advise changing a port config. This would be much simpler then, commensurate with the scope of the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11644#discussion_r55911638
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2014,8 +2014,10 @@ private[spark] object Utils extends Logging {
} catch {
case e: Exception if isBindCollision(e) =>
if (offset >= maxRetries) {
- val exceptionMessage =
- s"${e.getMessage}: Service$serviceString failed after $maxRetries retries!"
+ val exceptionMessage = s"${e.getMessage}: Service$serviceString failed after " +
+ s"$maxRetries retries! Consider explicitly setting the appropriate port for the" +
--- End diff --
now you need a space after "the".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11644#discussion_r55908574
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2014,8 +2014,10 @@ private[spark] object Utils extends Logging {
} catch {
case e: Exception if isBindCollision(e) =>
if (offset >= maxRetries) {
- val exceptionMessage =
- s"${e.getMessage}: Service$serviceString failed after $maxRetries retries!"
+ val exceptionMessage = s"${e.getMessage}: Service$serviceString failed after " +
+ s"$maxRetries retries! Consider explicitly setting the appropriate port for" +
--- End diff --
Man, that's tricky.
But in the case where `serviceString` is empty, this would look odd:
Consider explicitly setting the appropriate port for (for example spark.ui.port for SparkUI)
Perhaps `serviceString` should be changed so that it's "Service" if `serviceName` is empty. Or make sure that it's never empty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195604553
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195551694
**[Test build #52948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52948/consoleFull)** for PR 11644 at commit [`8177e69`](https://github.com/apache/spark/commit/8177e691540bdc583d3095b0463d4123482d2096).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195166923
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11644#issuecomment-195620582
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org