You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/13 09:51:41 UTC

[GitHub] [netbeans] MartinBalin opened a new issue, #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

MartinBalin opened a new issue, #4113:
URL: https://github.com/apache/netbeans/issues/4113

   ### Apache NetBeans version
   
   Apache NetBeans latest daily build
   
   ### What happened
   
   Installed VSNetBeans 13.0.1073 build from master and icons are broken on latest VSCode 1.67, works with 1.63.1
   ![Screenshot 2022-05-13 at 11 50 17](https://user-images.githubusercontent.com/26064232/168258800-8bec82dc-55e8-492f-8dc0-2e5b1e990d31.png)
   
   
   
   ### How to reproduce
   
   Install VSIX and open any gradle or maven project.
   
   ### Did this work correctly in an earlier version?
   
   Apache NetBeans 13
   
   ### Operating System
   
   macOS
   
   ### JDK
   
   graalVM 22.1 EE JDK11
   
   ### Apache NetBeans packaging
   
   Apache VSNetBeans for VSCode
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request?
   
   No
   
   ### Code of Conduct
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
sdedic commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1144841457

   @MartinBalin seems I've lost the race -- there are already at least two issues filed on this: microsoft/vscode#151087 and microsoft/vscode#150610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin closed issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
MartinBalin closed issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views 
URL: https://github.com/apache/netbeans/issues/4113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1143716267

   Yes, please file it with your sample VSIX.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
sdedic commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1142054342

   OK from the NBLS user's point of view, I still need to file a bug for vscode to make a real fix, will reference it here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1144852413

   And it also seems fixed by https://github.com/microsoft/vscode/pull/151090 so some next iteration of vscode will have it fixed. Hopefully correctly now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] sdedic commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
sdedic commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1126264052

   Actually it seems that this is a bug in vscode - I traced that down to commits [vscode/#d79928](https://github.com/microsoft/vscode/commit/d79928be53a807a9bff45814b6dab65bae685879) and [vscode/#a9c3c0](https://github.com/microsoft/vscode/commit/a9c3c0e4b0384fe2b2c907b94a99fda18d3f34a6) -- `ThemeIcon` specification is completely ignored in vscode 1.67, if the `TreeItem` has a `resourceUri` defined. I am going to file a bug with an example code for vscode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1142035469

   is this ok now ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin commented on issue #4113: VSNetBeans: Latest VSCode 1.67 breaks icons in projects views

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on issue #4113:
URL: https://github.com/apache/netbeans/issues/4113#issuecomment-1288873933

   Not longer a problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists