You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "rkdfx (via GitHub)" <gi...@apache.org> on 2026/05/23 17:41:22 UTC
[PR] CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment [camel]
rkdfx opened a new pull request, #23485:
URL: https://github.com/apache/camel/pull/23485
# Description
Adds a new consumer-side URI option `enableBatchIndexAcknowledgment` to the `camel-pulsar`
component.
The Pulsar client's `ConsumerBuilder` supports
`enableBatchIndexAcknowledgment(boolean)` to allow each message in a batch to be acknowledged
independently. With the option disabled (the Pulsar client default), a single failed
acknowledgment causes the broker to redeliver the entire batch — including messages that were
processed successfully. The component previously built the `ConsumerBuilder` without invoking
this method and exposed no URI parameter to configure it.
This change:
- Adds the option as a `@UriParam(label = "consumer")` field on `PulsarConfiguration` with
default `false` (matches the Pulsar client's own default — no behaviour change for existing
routes).
- Wires it into `CommonCreationStrategyImpl` in the same shape as the existing `readCompacted`
option (unconditional pass-through onto the `ConsumerBuilder`).
- Adds a default-value assertion to `PulsarComponentTest.testPulsarEndpointDefaultConfiguration`
and a new URI-parsing test `testPulsarEndpointEnableBatchIndexAcknowledgment`.
Enabling this option also requires the Pulsar broker to be configured with
`acknowledgmentAtBatchIndexLevelEnabled=true` for the per-message acknowledgments to take
effect. This is documented in the option's description.
Resolves https://issues.apache.org/jira/browse/CAMEL-23443
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23485:
URL: https://github.com/apache/camel/pull/23485#issuecomment-4527915469
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment [camel]
Posted by "rkdfx (via GitHub)" <gi...@apache.org>.
rkdfx commented on PR #23485:
URL: https://github.com/apache/camel/pull/23485#issuecomment-4528359077
I've committed all generated files after running `mvn clean install -DskipTests` which was missing that's why build failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23485:
URL: https://github.com/apache/camel/pull/23485#issuecomment-4528572141
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `catalog/camel-catalog`
- `components/camel-pulsar`
- `dsl/camel-componentdsl`
- `dsl/camel-endpointdsl`
<details><summary>All tested modules (11 modules)</summary>
- Camel :: Catalog :: Camel Catalog
- Camel :: Component DSL
- Camel :: Endpoint DSL
- Camel :: JBang :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Validate
- Camel :: Launcher :: Container
- Camel :: Pulsar
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26359837529)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23485:
URL: https://github.com/apache/camel/pull/23485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org