You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by st...@duboce.net on 2010/12/08 02:13:55 UTC

Re: Review Request: HBASE-1861 : Multi-family support for HFileOutputFormat

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1272/#review2044
-----------------------------------------------------------

Ship it!


+1  Excellent.


src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
<http://review.cloudera.org/r/1272/#comment6448>

    Should this behavior be documented in method javadoc?


- stack


On 2010-12-07 16:07:54, Nicolas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1272/
> -----------------------------------------------------------
> 
> (Updated 2010-12-07 16:07:54)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> support writing to multiple column families for HFileOutputFormat.  also, added a max threshold for PutSortReducer because we had some pathological row cases.
> 
> 
> This addresses bug HBASE-1861.
>     http://issues.apache.org/jira/browse/HBASE-1861
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java 8ccdf4d 
>   src/main/java/org/apache/hadoop/hbase/mapreduce/PutSortReducer.java 5fb3e83 
>   src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java c5d56cc 
> 
> Diff: http://review.cloudera.org/r/1272/diff
> 
> 
> Testing
> -------
> 
> mvn test -Dtest=ThestHFileOutputFormat
> internal MR testing
> 
> 
> Thanks,
> 
> Nicolas
> 
>