You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/08/15 16:27:01 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #15564: [TVMScript] Use triple-quoted python strings for metadata

Lunderberg opened a new pull request, #15564:
URL: https://github.com/apache/tvm/pull/15564

   Prior to this commit, all metadata was output as a single-quoted python string with escaped newlines.  This single line could become extremely long, which can cause some text editors to run slowly (e.g. emacs).
   
   This commit updates the TVMScript printer to instead output the metadata using a triple-quoted python string with embedded newlines. Because the metadata is a pretty-printed JSON string, it contains frequent newlines that prevent the line length from causing editor lag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #15564: [TVMScript] Use triple-quoted python strings for metadata

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #15564:
URL: https://github.com/apache/tvm/pull/15564#issuecomment-1679261490

   Updated PR to target `main`, as this change does not depend on any Relax-specific TVMScript handling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15564: [TVMScript] Use triple-quoted python strings for metadata

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15564:
URL: https://github.com/apache/tvm/pull/15564#issuecomment-1679254049

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] quic-sanirudh merged pull request #15564: [TVMScript] Use triple-quoted python strings for metadata

Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh merged PR #15564:
URL: https://github.com/apache/tvm/pull/15564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org