You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2018/08/14 01:57:48 UTC

httpcomponents-core git commit: Javadoc. Do not nest in else clauses unnecessarily. Don't hide ivars.Javadoc. Comment empty block.

Repository: httpcomponents-core
Updated Branches:
  refs/heads/master 71dbc7476 -> 22355f0b2


Javadoc. Do not nest in else clauses unnecessarily. Don't hide
ivars.Javadoc. Comment empty block.

Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/commit/22355f0b
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/tree/22355f0b
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/diff/22355f0b

Branch: refs/heads/master
Commit: 22355f0b29be29af7d0edf46931a345351c501d5
Parents: 71dbc74
Author: Gary Gregory <ga...@gmail.com>
Authored: Mon Aug 13 19:57:45 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Mon Aug 13 19:57:45 2018 -0600

----------------------------------------------------------------------
 .../hc/core5/http/io/entity/HttpEntityWrapper.java       |  4 +++-
 .../hc/core5/http/io/entity/SerializableEntity.java      | 11 ++++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/22355f0b/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEntityWrapper.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEntityWrapper.java b/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEntityWrapper.java
index f162859..154f95f 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEntityWrapper.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEntityWrapper.java
@@ -54,11 +54,13 @@ public class HttpEntityWrapper implements HttpEntity {
 
     /**
      * Creates a new entity wrapper.
+     *
+     * @param wrappedEntity the entity to wrap.
      */
     public HttpEntityWrapper(final HttpEntity wrappedEntity) {
         super();
         this.wrappedEntity = Args.notNull(wrappedEntity, "Wrapped entity");
-    } // constructor
+    }
 
     @Override
     public boolean isRepeatable() {

http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/22355f0b/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java b/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
index c1b5163..b7f0beb 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
@@ -70,12 +70,16 @@ public class SerializableEntity extends AbstractHttpEntity {
     }
 
     /**
+     * Creates new instance of this class.
+     *
+     * @param serializable The object to serialize.
+     *
      * @since 4.3
      */
-    public SerializableEntity(final Serializable ser) {
+    public SerializableEntity(final Serializable serializable) {
         super();
-        Args.notNull(ser, "Source object");
-        this.objRef = ser;
+        Args.notNull(serializable, "Source object");
+        this.objRef = serializable;
     }
 
     private void createBytes(final Serializable ser) throws IOException {
@@ -127,6 +131,7 @@ public class SerializableEntity extends AbstractHttpEntity {
 
     @Override
     public void close() throws IOException {
+        // do nothing.
     }
 
 }