You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/02 05:54:48 UTC
[GitHub] [flink] JingsongLi opened a new pull request #10741:
[FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
JingsongLi opened a new pull request #10741: [FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
URL: https://github.com/apache/flink/pull/10741
## What is the purpose of the change
Bug when use JDBC sink with float type.
## Brief change log
In flink
- SQL, we regard float as java float.
- But in JDBC, real type is java float, float/double are java double.
We have dealt with data very well in JDBCUtils, but mismatch in JDBCTypeUtil to match java float to JDBC float.
## Verifying this change
`JDBCUpsertTableSinkITCase.testReal`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10741: [FLINK-15443][jdbc] Fix
mismatch between Java float and JDBC float
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10741: [FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
URL: https://github.com/apache/flink/pull/10741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10741: [FLINK-15443][jdbc] Fix
mismatch between Java float and JDBC float
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10741: [FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
URL: https://github.com/apache/flink/pull/10741#issuecomment-570129932
<!--
Meta data
Hash:b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b1d08ddf274f9d0f101708d896fc5ecd4bd78e05
-->
## CI report:
* b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10741:
[FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10741: [FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
URL: https://github.com/apache/flink/pull/10741#issuecomment-570129932
<!--
Meta data
Hash:b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840208 TriggerType:PUSH TriggerID:b1d08ddf274f9d0f101708d896fc5ecd4bd78e05
-->
## CI report:
* b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10741:
[FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10741: [FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
URL: https://github.com/apache/flink/pull/10741#issuecomment-570129932
<!--
Meta data
Hash:b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142840208 TriggerType:PUSH TriggerID:b1d08ddf274f9d0f101708d896fc5ecd4bd78e05
-->
## CI report:
* b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142840208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10741: [FLINK-15443][jdbc] Fix
mismatch between Java float and JDBC float
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10741: [FLINK-15443][jdbc] Fix mismatch between Java float and JDBC float
URL: https://github.com/apache/flink/pull/10741#issuecomment-570124304
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b1d08ddf274f9d0f101708d896fc5ecd4bd78e05 (Thu Jan 02 05:57:06 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services