[GitHub] andretadeu commented on issue #2: [MJDEPS-16] Setup 'jdeps' goal alongside with 'jdkinternals'

[GitBox <gi...@apache.org>]

andretadeu commented on issue #2: [MJDEPS-16] Setup 'jdeps' goal alongside with 'jdkinternals'
URL: https://github.com/apache/maven-jdeps-plugin/pull/2#issuecomment-457589914
 
 
   Hi Robert!
   
   The plugin have several issues:
   
      - The plugin wasn't placing '-jdkinternals' parameters in some
      occasions, which reflected in some tests.
      - In my view, the plugin needed a task where I don't have to use
      '-jdkinternals', because the user may wants to know if one library is using
      any java.* module, not only the internals. That's why I used the task to do
      so. I was intending to run 'mvn jdeps:jdeps' and 'mvn jdeps:jdkinternals'
      in different situations, without having to setup a parameter.
      - The jdeps -m usage was not working as expected, as far as I can
      remember, the parameter wasn't being set correctly.
      - And finally, in some occasions, I had to add module-info.class into
      the target path, because jdeps works differently when the target points to
      the folder where it is and when the target points to the file itself (I
      don't know why).
   
   If you want me to open JIRA ticket for each issue, I'll do that. I'm
   accepting suggestions about how any of the issues should be dealt.
   It's my fault about the first PR. It's just a README addition that is not
   related to MJDEPS-16, but I missed it in the title of the email.
   
   Thanks,
   
   André Tadeu de Carvalho
   
   
   Em sex, 25 de jan de 2019 às 09:05, Robert Scholte <no...@github.com>
   escreveu:
   
   > I'm a bit confused: MJDEPS-16 is about extending the existing goals by
   > scanning the dependencies for internal JDK usage too (by default). So why a
   > new goal? That would be a new MJDEPS issue.
   > It seems to me these PRs are much bigger than MJDEPS-16
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-jdeps-plugin/pull/2#issuecomment-457538127>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAgNNXcfYEVkOLQvp06UvWOHxyA2IMrLks5vGuUHgaJpZM4aNED3>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services