[GitHub] [nifi] MikeThomsen commented on a change in pull request #4231: NIFI-7037 Split off username and password fields for GetMongo processor

[GitBox <gi...@apache.org>]

MikeThomsen commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r419174198



##########
File path: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##########
@@ -271,4 +302,59 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
         }
 
     }
+
+    @OnScheduled
+    public void createClient(ProcessContext context) throws IOException {

Review comment:
       @alopresto We started moving toward using a controller service to manage the client connection I think ~3 releases ago. The best place for these changes might be there, so we can start moving toward deprecating per-processor connection management altogether.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org