You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2017/04/27 15:31:36 UTC
[GitHub] beam pull request #2739: [BEAM-2096] Make DataflowMetrics more resilient
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/2739
[BEAM-2096] Make DataflowMetrics more resilient
DataflowMetrics seems to have many hard-coded assumptions about what will be
returned by the Dataflow service that, which will likely break when users
use new types of metrics or if the Dataflow service makes minor adjustments
in our it sends metrics back to the user.
In order for code to continue working in these cases, handle errors by logging
and skipping.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam metrics-npe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2739
----
commit 4f418cdd57c5ebff2f406c1487db7dee420e3df6
Author: Dan Halperin <dh...@google.com>
Date: 2017-04-27T15:30:47Z
[BEAM-2096] Make DataflowMetrics more resilient
DataflowMetrics seems to have many hard-coded assumptions about what will be
returned by the Dataflow service that, which will likely break when users
use new types of metrics or if the Dataflow service makes minor adjustments
in our it sends metrics back to the user.
In order for code to continue working in these cases, handle errors by logging
and skipping.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2739: [BEAM-2096] Make DataflowMetrics more resilient
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---