You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/22 11:19:04 UTC
[GitHub] [rocketmq] xxd763795151 opened a new pull request #2619: [ISSUE #2618]deleteTopic command support to delete the topic from which broker
xxd763795151 opened a new pull request #2619:
URL: https://github.com/apache/rocketmq/pull/2619
**Make sure set the target branch to `develop`**
## What is the purpose of the change
deleteTopic command support to delete the topic from which broker, as follow:
-b,--brokerAddr <arg> delete topic from which broker, eg: 192.168.0.1:10911
-c,--clusterName <arg> delete topic from which cluster
-h,--help Print help
-n,--namesrvAddr <arg> Name server address list, eg: 192.168.0.1:9876;192.168.0.2:9876
-t,--topic <arg> topic name
can choose a broker to delete.
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2619: [ISSUE #2618]deleteTopic command support to delete the topic from which broker
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2619:
URL: https://github.com/apache/rocketmq/pull/2619#issuecomment-765338402
[](https://coveralls.io/builds/36523963)
Coverage increased (+0.2%) to 52.047% when pulling **46875210d85a79bf4c196a4b787a5d18d3d9a14e on xxd763795151:topic_delete_broker** into **8b63761f535ed1f6be3ccf1c5dff3ea761c46e92 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2619: [ISSUE #2618]deleteTopic command support to delete the topic from which broker
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2619:
URL: https://github.com/apache/rocketmq/pull/2619#issuecomment-765343998
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=h1) Report
> Merging [#2619](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=desc) (4687521) into [develop](https://codecov.io/gh/apache/rocketmq/commit/6af12592af95916cc0b4512f2bab60ee18f62b8b?el=desc) (6af1259) will **increase** coverage by `0.38%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2619 +/- ##
=============================================
+ Coverage 45.80% 46.18% +0.38%
- Complexity 4306 4344 +38
=============================================
Files 547 547
Lines 36246 36264 +18
Branches 4808 4813 +5
=============================================
+ Hits 16601 16750 +149
+ Misses 17552 17426 -126
+ Partials 2093 2088 -5
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.29% <0.00%> (-0.02%)` | `25.00 <0.00> (ø)` | |
| [...mmon/protocol/header/DeleteTopicRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0RlbGV0ZVRvcGljUmVxdWVzdEhlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...der/namesrv/DeleteTopicInNamesrvRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL25hbWVzcnYvRGVsZXRlVG9waWNJbk5hbWVzcnZSZXF1ZXN0SGVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==) | `36.42% <0.00%> (+7.90%)` | `17.00 <0.00> (+2.00)` | |
| [...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vUm91dGVJbmZvTWFuYWdlci5qYXZh) | `38.27% <0.00%> (-0.63%)` | `28.00 <0.00> (+1.00)` | :arrow_down: |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | `9.00% <0.00%> (-1.00%)` | |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `56.49% <0.00%> (-0.06%)` | `109.00% <0.00%> (ø%)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (ø)` | `26.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `66.52% <0.00%> (+0.10%)` | `79.00% <0.00%> (ø%)` | |
| ... and [21 more](https://codecov.io/gh/apache/rocketmq/pull/2619/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=footer). Last update [6af1259...4687521](https://codecov.io/gh/apache/rocketmq/pull/2619?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org