You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/14 06:08:47 UTC

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #896: createnetwork: Fixing missing vlan parameter

davidjumani opened a new pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896


   Fixes inability to specify vlan for isolated networks
   
   ![Screenshot from 2020-12-14 11-35-27](https://user-images.githubusercontent.com/8244774/102046173-c4f14380-3e00-11eb-89f4-bb4afcc11a11.png)
   
   Also reduces the issue when the isolated tab pops up seconds later


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744207543


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#discussion_r542158704



##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -18,24 +18,24 @@
 <template>
   <div class="form-layout">
     <a-tabs defaultActiveKey="1" :animated="false">
-      <a-tab-pane :tab="$t('label.isolated')" key="1" v-if="this.isAdvancedZoneWithoutSGAvailable()">
-        <CreateIsolatedNetworkForm
+      <a-tab-pane :tab="$t('label.l2')" key="1">

Review comment:
       @davidjumani can the first network/tab be isolated, then l2 and then shared? Most people would want to see isolated by default; also this is reused in the deploy VM form.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744206453


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744207170


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744207126


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744194224


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani closed pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
davidjumani closed pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744206453


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#discussion_r542163681



##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -18,24 +18,24 @@
 <template>
   <div class="form-layout">
     <a-tabs defaultActiveKey="1" :animated="false">
-      <a-tab-pane :tab="$t('label.isolated')" key="1" v-if="this.isAdvancedZoneWithoutSGAvailable()">
-        <CreateIsolatedNetworkForm
+      <a-tab-pane :tab="$t('label.l2')" key="1">

Review comment:
       It can, but then l2 form pops open first since the if condition on the isolated form takes time to evaluate, and the reordering of the tabs once evaluated looks messy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744224508


   @davidjumani I'm unable to reproduce the issue of not being able to pass the vlan id when chosen isolated n/w's offering has specifyVlan set to true.
   However, the fix for tab looks good


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #896: createnetwork: Fixing missing vlan parameter

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#issuecomment-744215100






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org