You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "igorbernstein2 (via GitHub)" <gi...@apache.org> on 2023/02/01 15:52:05 UTC

[GitHub] [beam] igorbernstein2 commented on a diff in pull request #24015: [Bigtable] Migrate BigtableIO to use the veneer client under the hood

igorbernstein2 commented on code in PR #24015:
URL: https://github.com/apache/beam/pull/24015#discussion_r1093411559


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableClientWrapper.java:
##########
@@ -0,0 +1,94 @@
+/*

Review Comment:
   Yea, Im a bit confused by this as well. BigtableHBaseVeneerSettings shouldnt be relevant here. You would just need to instantiate BigtableDataClient & BigtableTableAdminClient via their settings



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org