You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by Hiranya Jayathilaka <hi...@gmail.com> on 2011/12/24 15:32:01 UTC
Some Inconsistencies in the Modules POMs
Hi Folks,
I'm in the process of doing some clean up work in the Synapse trunk. I
noticed that following modules don't specify the root POM as the parent:
xar-maven-plugin (No parent definition)
securevault (Defines org.apache:apache as the parent)
Any reason for these inconsistencies?
Thanks
--
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.; http://wso2.org
E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com
Re: Some Inconsistencies in the Modules POMs
Posted by indika kumara <in...@gmail.com>.
+1... and thanks ...
~ Indika
On Sun, Dec 25, 2011 at 8:32 PM, Hiranya Jayathilaka
<hi...@gmail.com>wrote:
> Hi Indika,
>
> On Sun, Dec 25, 2011 at 4:09 AM, indika kumara <in...@gmail.com>wrote:
>
>> Hi Hiranya,
>>
>> Regarding securevault,I did that change to make it self-contained. The
>> way I have done may be wrong. If so, cloud you please correct it? Honestly,
>> I have zero knowledge about maven.
>>
>
> I think we can set the Synapse root pom as the parent of securevault
> module. Securevault does not depend on any other Synapse modules. So it is
> a self contained module. People who are using it will not get affected by
> changing the parent of the module. Currently securevault defines its own
> Axis2/Axiom versions. By changing the parent to Synapse root pom we can get
> rid of these additional version definitions and reuse the dependencies
> defined at the root level. I will try this out and fix it in the trunk if
> everything's ok.
>
> Thanks,
> Hiranya
>
>
>>
>> Thanks,
>>
>> Indika
>>
>> On Sun, Dec 25, 2011 at 1:32 AM, Hiranya Jayathilaka <
>> hiranya911@gmail.com> wrote:
>>
>>> Hi Folks,
>>>
>>> I'm in the process of doing some clean up work in the Synapse trunk. I
>>> noticed that following modules don't specify the root POM as the parent:
>>>
>>> xar-maven-plugin (No parent definition)
>>> securevault (Defines org.apache:apache as the parent)
>>>
>>> Any reason for these inconsistencies?
>>>
>>> Thanks
>>> --
>>> Hiranya Jayathilaka
>>> Associate Technical Lead;
>>> WSO2 Inc.; http://wso2.org
>>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>>> Blog: http://techfeast-hiranya.blogspot.com
>>>
>>
>>
>
>
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
Re: Some Inconsistencies in the Modules POMs
Posted by Hiranya Jayathilaka <hi...@gmail.com>.
Hi Indika,
On Sun, Dec 25, 2011 at 4:09 AM, indika kumara <in...@gmail.com>wrote:
> Hi Hiranya,
>
> Regarding securevault,I did that change to make it self-contained. The way
> I have done may be wrong. If so, cloud you please correct it? Honestly, I
> have zero knowledge about maven.
>
I think we can set the Synapse root pom as the parent of securevault
module. Securevault does not depend on any other Synapse modules. So it is
a self contained module. People who are using it will not get affected by
changing the parent of the module. Currently securevault defines its own
Axis2/Axiom versions. By changing the parent to Synapse root pom we can get
rid of these additional version definitions and reuse the dependencies
defined at the root level. I will try this out and fix it in the trunk if
everything's ok.
Thanks,
Hiranya
>
> Thanks,
>
> Indika
>
> On Sun, Dec 25, 2011 at 1:32 AM, Hiranya Jayathilaka <hiranya911@gmail.com
> > wrote:
>
>> Hi Folks,
>>
>> I'm in the process of doing some clean up work in the Synapse trunk. I
>> noticed that following modules don't specify the root POM as the parent:
>>
>> xar-maven-plugin (No parent definition)
>> securevault (Defines org.apache:apache as the parent)
>>
>> Any reason for these inconsistencies?
>>
>> Thanks
>> --
>> Hiranya Jayathilaka
>> Associate Technical Lead;
>> WSO2 Inc.; http://wso2.org
>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>> Blog: http://techfeast-hiranya.blogspot.com
>>
>
>
--
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.; http://wso2.org
E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com
Re: Some Inconsistencies in the Modules POMs
Posted by indika kumara <in...@gmail.com>.
Hi Hiranya,
Regarding securevault,I did that change to make it self-contained. The way
I have done may be wrong. If so, cloud you please correct it? Honestly, I
have zero knowledge about maven.
Thanks,
Indika
On Sun, Dec 25, 2011 at 1:32 AM, Hiranya Jayathilaka
<hi...@gmail.com>wrote:
> Hi Folks,
>
> I'm in the process of doing some clean up work in the Synapse trunk. I
> noticed that following modules don't specify the root POM as the parent:
>
> xar-maven-plugin (No parent definition)
> securevault (Defines org.apache:apache as the parent)
>
> Any reason for these inconsistencies?
>
> Thanks
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
Re: Some Inconsistencies in the Modules POMs
Posted by Ruwan Linton <ru...@gmail.com>.
Thanks Hiranya. It's good to see the consistency in all modules.
Ruwan
On Tue, Dec 27, 2011 at 11:51 AM, Hiranya Jayathilaka
<hi...@gmail.com>wrote:
> Hi Ruwan,
>
> On Mon, Dec 26, 2011 at 10:48 PM, Ruwan Linton <ru...@gmail.com>wrote:
>
>> +1, root pom should only have dependencyManagement and not dependencies.
>> I guess now the xar maven plugin can point to the synapse parent too.
>>
>
> Yes. This is already done.
>
> Thanks,
> Hiranya
>
>
>>
>> Ruwan
>>
>>
>> On Mon, Dec 26, 2011 at 5:30 PM, Hiranya Jayathilaka <
>> hiranya911@gmail.com> wrote:
>>
>>>
>>>
>>> On Mon, Dec 26, 2011 at 5:08 PM, Andreas Veithen <
>>> andreas.veithen@gmail.com> wrote:
>>>
>>>> On Sat, Dec 24, 2011 at 15:32, Hiranya Jayathilaka <
>>>> hiranya911@gmail.com> wrote:
>>>> > Hi Folks,
>>>> >
>>>> > I'm in the process of doing some clean up work in the Synapse trunk. I
>>>> > noticed that following modules don't specify the root POM as the
>>>> parent:
>>>> >
>>>> > xar-maven-plugin (No parent definition)
>>>>
>>>> The reason for that is that the Synapse root POM specifies lots of
>>>> dependencies that are irrelevant for that plugin. To be usable as a
>>>> parent POM, the root POM should not specify any dependency at all.
>>>>
>>>
>>> I removed the entire 'dependencies' section from the root POM. Now it
>>> only has the dependency management section which defines dependency
>>> versions for the entire project. I just did a complete build (from a clean
>>> repo, with tests and reporting) and the dependency convergence report shows
>>> 100% convergence on all modules and at root.
>>>
>>> Thanks,
>>> Hiranya
>>>
>>>
>>>>
>>>> > securevault (Defines org.apache:apache as the parent)
>>>> >
>>>> > Any reason for these inconsistencies?
>>>> >
>>>> > Thanks
>>>> > --
>>>> > Hiranya Jayathilaka
>>>> > Associate Technical Lead;
>>>> > WSO2 Inc.; http://wso2.org
>>>> > E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>>>> > Blog: http://techfeast-hiranya.blogspot.com
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>>>> For additional commands, e-mail: dev-help@synapse.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> Hiranya Jayathilaka
>>> Associate Technical Lead;
>>> WSO2 Inc.; http://wso2.org
>>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>>> Blog: http://techfeast-hiranya.blogspot.com
>>>
>>
>>
>>
>> --
>> Ruwan Linton
>> Member, Apache Software Foundation; http://www.apache.org
>> Director of Engineering; http://adroitlogic.org
>>
>> phone: +94 11 282 7532
>> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
>> blog: http://blog.ruwan.org
>> linkedin: http://www.linkedin.com/in/ruwanlinton
>> google: http://www.google.com/profiles/ruwan.linton
>> tweet: http://twitter.com/ruwanlinton
>>
>>
>
>
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
--
Ruwan Linton
Member, Apache Software Foundation; http://www.apache.org
Director of Engineering; http://adroitlogic.org
phone: +94 11 282 7532
email: ruwan@adroitlogic.com; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://twitter.com/ruwanlinton
Re: Some Inconsistencies in the Modules POMs
Posted by Hiranya Jayathilaka <hi...@gmail.com>.
Hi Ruwan,
On Mon, Dec 26, 2011 at 10:48 PM, Ruwan Linton <ru...@gmail.com>wrote:
> +1, root pom should only have dependencyManagement and not dependencies. I
> guess now the xar maven plugin can point to the synapse parent too.
>
Yes. This is already done.
Thanks,
Hiranya
>
> Ruwan
>
>
> On Mon, Dec 26, 2011 at 5:30 PM, Hiranya Jayathilaka <hiranya911@gmail.com
> > wrote:
>
>>
>>
>> On Mon, Dec 26, 2011 at 5:08 PM, Andreas Veithen <
>> andreas.veithen@gmail.com> wrote:
>>
>>> On Sat, Dec 24, 2011 at 15:32, Hiranya Jayathilaka <hi...@gmail.com>
>>> wrote:
>>> > Hi Folks,
>>> >
>>> > I'm in the process of doing some clean up work in the Synapse trunk. I
>>> > noticed that following modules don't specify the root POM as the
>>> parent:
>>> >
>>> > xar-maven-plugin (No parent definition)
>>>
>>> The reason for that is that the Synapse root POM specifies lots of
>>> dependencies that are irrelevant for that plugin. To be usable as a
>>> parent POM, the root POM should not specify any dependency at all.
>>>
>>
>> I removed the entire 'dependencies' section from the root POM. Now it
>> only has the dependency management section which defines dependency
>> versions for the entire project. I just did a complete build (from a clean
>> repo, with tests and reporting) and the dependency convergence report shows
>> 100% convergence on all modules and at root.
>>
>> Thanks,
>> Hiranya
>>
>>
>>>
>>> > securevault (Defines org.apache:apache as the parent)
>>> >
>>> > Any reason for these inconsistencies?
>>> >
>>> > Thanks
>>> > --
>>> > Hiranya Jayathilaka
>>> > Associate Technical Lead;
>>> > WSO2 Inc.; http://wso2.org
>>> > E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>>> > Blog: http://techfeast-hiranya.blogspot.com
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>>> For additional commands, e-mail: dev-help@synapse.apache.org
>>>
>>>
>>
>>
>> --
>> Hiranya Jayathilaka
>> Associate Technical Lead;
>> WSO2 Inc.; http://wso2.org
>> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>> Blog: http://techfeast-hiranya.blogspot.com
>>
>
>
>
> --
> Ruwan Linton
> Member, Apache Software Foundation; http://www.apache.org
> Director of Engineering; http://adroitlogic.org
>
> phone: +94 11 282 7532
> email: ruwan@adroitlogic.com; cell: +94 77 341 3097
> blog: http://blog.ruwan.org
> linkedin: http://www.linkedin.com/in/ruwanlinton
> google: http://www.google.com/profiles/ruwan.linton
> tweet: http://twitter.com/ruwanlinton
>
>
--
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.; http://wso2.org
E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com
Re: Some Inconsistencies in the Modules POMs
Posted by Ruwan Linton <ru...@gmail.com>.
+1, root pom should only have dependencyManagement and not dependencies. I
guess now the xar maven plugin can point to the synapse parent too.
Ruwan
On Mon, Dec 26, 2011 at 5:30 PM, Hiranya Jayathilaka
<hi...@gmail.com>wrote:
>
>
> On Mon, Dec 26, 2011 at 5:08 PM, Andreas Veithen <
> andreas.veithen@gmail.com> wrote:
>
>> On Sat, Dec 24, 2011 at 15:32, Hiranya Jayathilaka <hi...@gmail.com>
>> wrote:
>> > Hi Folks,
>> >
>> > I'm in the process of doing some clean up work in the Synapse trunk. I
>> > noticed that following modules don't specify the root POM as the parent:
>> >
>> > xar-maven-plugin (No parent definition)
>>
>> The reason for that is that the Synapse root POM specifies lots of
>> dependencies that are irrelevant for that plugin. To be usable as a
>> parent POM, the root POM should not specify any dependency at all.
>>
>
> I removed the entire 'dependencies' section from the root POM. Now it only
> has the dependency management section which defines dependency versions for
> the entire project. I just did a complete build (from a clean repo, with
> tests and reporting) and the dependency convergence report shows 100%
> convergence on all modules and at root.
>
> Thanks,
> Hiranya
>
>
>>
>> > securevault (Defines org.apache:apache as the parent)
>> >
>> > Any reason for these inconsistencies?
>> >
>> > Thanks
>> > --
>> > Hiranya Jayathilaka
>> > Associate Technical Lead;
>> > WSO2 Inc.; http://wso2.org
>> > E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>> > Blog: http://techfeast-hiranya.blogspot.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>> For additional commands, e-mail: dev-help@synapse.apache.org
>>
>>
>
>
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
--
Ruwan Linton
Member, Apache Software Foundation; http://www.apache.org
Director of Engineering; http://adroitlogic.org
phone: +94 11 282 7532
email: ruwan@adroitlogic.com; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://twitter.com/ruwanlinton
Re: Some Inconsistencies in the Modules POMs
Posted by Andreas Veithen <an...@gmail.com>.
On Mon, Dec 26, 2011 at 13:00, Hiranya Jayathilaka <hi...@gmail.com> wrote:
>
>
> On Mon, Dec 26, 2011 at 5:08 PM, Andreas Veithen <an...@gmail.com>
> wrote:
>>
>> On Sat, Dec 24, 2011 at 15:32, Hiranya Jayathilaka <hi...@gmail.com>
>> wrote:
>> > Hi Folks,
>> >
>> > I'm in the process of doing some clean up work in the Synapse trunk. I
>> > noticed that following modules don't specify the root POM as the parent:
>> >
>> > xar-maven-plugin (No parent definition)
>>
>> The reason for that is that the Synapse root POM specifies lots of
>> dependencies that are irrelevant for that plugin. To be usable as a
>> parent POM, the root POM should not specify any dependency at all.
>
>
> I removed the entire 'dependencies' section from the root POM. Now it only
> has the dependency management section which defines dependency versions for
> the entire project. I just did a complete build (from a clean repo, with
> tests and reporting) and the dependency convergence report shows 100%
> convergence on all modules and at root.
Cool!
> Thanks,
> Hiranya
>
>>
>>
>> > securevault (Defines org.apache:apache as the parent)
>> >
>> > Any reason for these inconsistencies?
>> >
>> > Thanks
>> > --
>> > Hiranya Jayathilaka
>> > Associate Technical Lead;
>> > WSO2 Inc.; http://wso2.org
>> > E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
>> > Blog: http://techfeast-hiranya.blogspot.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
>> For additional commands, e-mail: dev-help@synapse.apache.org
>>
>
>
>
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
Re: Some Inconsistencies in the Modules POMs
Posted by Hiranya Jayathilaka <hi...@gmail.com>.
On Mon, Dec 26, 2011 at 5:08 PM, Andreas Veithen
<an...@gmail.com>wrote:
> On Sat, Dec 24, 2011 at 15:32, Hiranya Jayathilaka <hi...@gmail.com>
> wrote:
> > Hi Folks,
> >
> > I'm in the process of doing some clean up work in the Synapse trunk. I
> > noticed that following modules don't specify the root POM as the parent:
> >
> > xar-maven-plugin (No parent definition)
>
> The reason for that is that the Synapse root POM specifies lots of
> dependencies that are irrelevant for that plugin. To be usable as a
> parent POM, the root POM should not specify any dependency at all.
>
I removed the entire 'dependencies' section from the root POM. Now it only
has the dependency management section which defines dependency versions for
the entire project. I just did a complete build (from a clean repo, with
tests and reporting) and the dependency convergence report shows 100%
convergence on all modules and at root.
Thanks,
Hiranya
>
> > securevault (Defines org.apache:apache as the parent)
> >
> > Any reason for these inconsistencies?
> >
> > Thanks
> > --
> > Hiranya Jayathilaka
> > Associate Technical Lead;
> > WSO2 Inc.; http://wso2.org
> > E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> > Blog: http://techfeast-hiranya.blogspot.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>
>
--
Hiranya Jayathilaka
Associate Technical Lead;
WSO2 Inc.; http://wso2.org
E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com
Re: Some Inconsistencies in the Modules POMs
Posted by Andreas Veithen <an...@gmail.com>.
On Sat, Dec 24, 2011 at 15:32, Hiranya Jayathilaka <hi...@gmail.com> wrote:
> Hi Folks,
>
> I'm in the process of doing some clean up work in the Synapse trunk. I
> noticed that following modules don't specify the root POM as the parent:
>
> xar-maven-plugin (No parent definition)
The reason for that is that the Synapse root POM specifies lots of
dependencies that are irrelevant for that plugin. To be usable as a
parent POM, the root POM should not specify any dependency at all.
> securevault (Defines org.apache:apache as the parent)
>
> Any reason for these inconsistencies?
>
> Thanks
> --
> Hiranya Jayathilaka
> Associate Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org