You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/02/17 09:50:25 UTC
[GitHub] flink pull request: [FLINK-3309] [py] Resolve Maven warnings
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1649
[FLINK-3309] [py] Resolve Maven warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3309_py_maven
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1649
----
commit 0a231417522e78292f2bbec7b202c44d51ddb608
Author: zentol <s....@web.de>
Date: 2016-02-01T11:07:50Z
[FLINK-3309] [py] Resolve Maven warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3309] [py] Resolve Maven warnings
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1649#discussion_r53151157
--- Diff: flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java ---
@@ -432,11 +436,11 @@ private void createPrintSink(PythonOperationInfo info) throws IOException {
}
private void createBroadcastVariable(PythonOperationInfo info) throws IOException {
- UdfOperator op1 = (UdfOperator) sets.get(info.parentID);
- DataSet op2 = (DataSet) sets.get(info.otherID);
+ UdfOperator<?> op1 = (UdfOperator) sets.get(info.parentID);
+ DataSet<?> op2 = (DataSet) sets.get(info.otherID);
op1.withBroadcastSet(op2, info.name);
- Configuration c = ((UdfOperator) op1).getParameters();
+ Configuration c = (op1).getParameters();
--- End diff --
Can we remove parenthesis around `op1`? (`op1.getParameters()`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3309] [py] Resolve Maven warnings
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1649#discussion_r53151610
--- Diff: flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java ---
@@ -432,11 +436,11 @@ private void createPrintSink(PythonOperationInfo info) throws IOException {
}
private void createBroadcastVariable(PythonOperationInfo info) throws IOException {
- UdfOperator op1 = (UdfOperator) sets.get(info.parentID);
- DataSet op2 = (DataSet) sets.get(info.otherID);
+ UdfOperator<?> op1 = (UdfOperator) sets.get(info.parentID);
+ DataSet<?> op2 = (DataSet) sets.get(info.otherID);
op1.withBroadcastSet(op2, info.name);
- Configuration c = ((UdfOperator) op1).getParameters();
+ Configuration c = (op1).getParameters();
--- End diff --
sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3309] [py] Resolve Maven warnings
Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/1649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3309] [py] Resolve Maven warnings
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1649#issuecomment-193723785
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3309] [py] Resolve Maven warnings
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1649#issuecomment-185153138
Looks good, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---