You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/04/19 04:16:44 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request, #20136: [improve][broker] Optimize delayed metadata index bitmap

mattisonchao opened a new pull request, #20136:
URL: https://github.com/apache/pulsar/pull/20136

   ### Motivation
   
   Add `runOptimize` to make the bitmap do some optimisation.
   
   ### Modifications
   
   - call `runOptimize` before building segment metadata.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #20136: [improve][broker] Optimize delayed metadata index bitmap

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on PR #20136:
URL: https://github.com/apache/pulsar/pull/20136#issuecomment-1514135542

   LGTM
   
   Also can optimization `ImmutableBucket.recoverDelayedIndexBitMapAndNumber` and `asyncMergeBucketSnapshot` to reduce memory.
   
   https://github.com/apache/pulsar/blob/c4aec6661e795c46181dc1fa79282065fa875768/pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java#L473-L488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao closed pull request #20136: [improve][broker] Optimize delayed metadata index bitmap

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #20136: [improve][broker] Optimize delayed metadata index bitmap
URL: https://github.com/apache/pulsar/pull/20136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao merged pull request #20136: [improve][broker] Optimize delayed metadata index bitmap

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao merged PR #20136:
URL: https://github.com/apache/pulsar/pull/20136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #20136: [improve][broker] Optimize delayed metadata index bitmap

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on PR #20136:
URL: https://github.com/apache/pulsar/pull/20136#issuecomment-1514779599

   Also need optimization `lastMutableBucket.delayedIndexBitMap`~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org