You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/11 05:08:59 UTC

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5137: Fix the ConstantValueDictionary

jackjlli commented on a change in pull request #5137: Fix the ConstantValueDictionary
URL: https://github.com/apache/incubator-pinot/pull/5137#discussion_r390748409
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/BaseVirtualColumnProvider.java
 ##########
 @@ -39,7 +39,7 @@
 
   public DataFileReader buildReader(VirtualColumnContext context) {
     if (context.getFieldSpec().isSingleValueField()) {
-      return new ConstantSingleValueInvertedIndex(0);
+      return new ConstantSingleValueSortedIndex(0);
 
 Review comment:
   Why is this class renamed to SortedIndex instead of InvertedIndex?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org