You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/07 06:13:00 UTC
[jira] [Commented] (CB-12994) Screen orientation plugin fails to
install on some systems
[ https://issues.apache.org/jira/browse/CB-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077660#comment-16077660 ]
ASF GitHub Bot commented on CB-12994:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/21
CB-12994: (android, blackberry) add es6-promise-plugin from npm
this closes #15
### Platforms affected
android, blackberry
### What does this PR do?
https://issues.apache.org/jira/browse/CB-12994
Changes the plugin to not install es6-promise-plugin dependency from git, but instead install it from npm.
### What testing has been done on this change?
Travis and AppVeyor is going to do all the testing
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit e6ccbc4ff56d24afc755032d711d6db2ae59ca0f
Author: Maxime Bertonnier <m....@gmail.com>
Date: 2017-05-12T15:57:25Z
CB-12994: (android, blackberry) add es6-promise-plugin from npm
this closes #15
----
> Screen orientation plugin fails to install on some systems
> ----------------------------------------------------------
>
> Key: CB-12994
> URL: https://issues.apache.org/jira/browse/CB-12994
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-screen-orientation
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Labels: easyfix, triaged
>
> Users report that cordova-plugin-screen-orientation cannot be added on their sysstems because of the es6 promises plugin dependency:
> https://github.com/apache/cordova-plugin-screen-orientation/pull/15
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org