You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mattyb149 (via GitHub)" <gi...@apache.org> on 2023/06/20 21:00:22 UTC

[GitHub] [nifi] mattyb149 opened a new pull request, #7416: NIFI-7016: Fix Groovy File functions available for FlowFile in ExecuteGroovyScript

mattyb149 opened a new pull request, #7416:
URL: https://github.com/apache/nifi/pull/7416

   # Summary
   
   [NIFI-7016](https://issues.apache.org/jira/browse/NIFI-7016) This PR fixes a bug from NIFI-6145 where Groovy file functions (`withInputStream`, e.g.) were added to ExecuteGroovyScript. These didn't adhere to the Groovy spec which states the methods should return the value of the evaluated Closure versus the object it was called upon. Also removed some warnings.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [x] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen commented on pull request #7416: NIFI-7016: Fix Groovy File functions available for FlowFile in ExecuteGroovyScript

Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #7416:
URL: https://github.com/apache/nifi/pull/7416#issuecomment-1600584944

   Put the wrong issue # in the commit line, closing manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen closed pull request #7416: NIFI-7016: Fix Groovy File functions available for FlowFile in ExecuteGroovyScript

Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen closed pull request #7416: NIFI-7016: Fix Groovy File functions available for FlowFile in ExecuteGroovyScript
URL: https://github.com/apache/nifi/pull/7416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org