[jira] [Comment Edited] (IGNITE-11435) SQL: Create a view with query history

["Vladimir Ozerov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791410#comment-16791410 ] 

Vladimir Ozerov edited comment on IGNITE-11435 at 3/13/19 7:42 AM:
-------------------------------------------------------------------

[~jooger], my comments:
# {{LOCAL_SQL_QUERY_HISTORY.QUERY}} should be renamed to {{SQL}} to be consistent with running queries view
# {{LAST_QUERY_START}} should be {{LAST_START_TIME}} for the same reason as p.1
# {{CALLS}} is misleading term here, because in SQL "call" typically means execution of a stored procedure. Let's rename it to {{EXECUTIONS}}
# {{EXECUTIONS}} and {{FAILURES}} should be {{long}}, not {{int}}, because it is very easy to exceed Integer.MAX_VALUE. {{QueryHistoryMetrics}} and {{QueryHistoryMetricsValue}} should be fixed accordingly.
# Test coverage is insufficient. We should test increment of executions and failures, min and max duration changes, proper handling of schemas. Probably custom SQL functions will be needed to test failures and durations.


was (Author: vozerov):
[~jooger], my comments:
# {{LOCAL_SQL_QUERY_HISTORY.QUERY}} should be renamed to {{SQL}} to be consistent with running queries view
# {{LAST_QUERY_START}} should be {{LAST_START_TIME}} for the same reason as p.1
# {{CALLS}} is misleading term here, because in SQL "call" typically means execution of a stored procedure. Let's rename it to {{EXECUTIONS}}
# {{EXECUTIONS}} and {{FAILURES}} should be {{long}}, not {{int}}, because it is very easy to exceed Integer.MAX_VALUE. {{QueryHistoryMetrics}} and {{QueryHistoryMetricsValue}} should be fixed accordingly.

> SQL: Create a view with query history
> -------------------------------------
>
>                 Key: IGNITE-11435
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11435
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Yury Gerzhedovich
>            Assignee: Yury Gerzhedovich
>            Priority: Major
>              Labels: iep-29
>             Fix For: 2.8
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Need to expose Query History view - LOCAL_SQL_QUERY_HISTORY
> List of columns:
> SCHEMA_NAME - name of schema
> QUERY - query text
> LOCAL - flag of local query
> CALLS - number of execution of the query
> FAILURES - number of failures for the query
> DURATION_MIN - minimum duration of execution
> DURATION_MAX - maximum duration of execution
> LAST_QUERY_START - time of the last start of execution
>  
> see QueryHistoryMetrics class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)