You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2017/04/06 14:20:25 UTC

[Bug 60961] New: ViewResultsTree: Selection gets lost after refresh

https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

            Bug ID: 60961
           Summary: ViewResultsTree: Selection gets lost after refresh
           Product: JMeter
           Version: 3.2
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: logox01@gmx.at
  Target Milestone: ---

(JMeter 3.2 rc2)
I have a testplan containing a ViewResultsTree listener and a ThreadGroup with
HTTPRequests.
When I run the testplan and select an item in the results tree, this selection
gets lost as soon as new items show up.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Felix Schumacher <fe...@internetallee.de> ---
This will be included in version 3.3

@logox01 it would be nice, if you could test the next nightly and report if it
fixes your use case.

Date: Sun Jul 16 15:55:58 2017
New Revision: 1802075

URL: http://svn.apache.org/viewvc?rev=1802075&view=rev
Log:
Try to keep status of selected and expanded elements in View Results Tree when
new elements are added.

Bugzilla Id: 60961

Modified:
   
jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh (nightly)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ViewResultsTree: Selection  |ViewResultsTree: Selection
                   |gets lost after refresh     |gets lost after refresh
                   |                            |(nightly)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 35142
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35142&action=edit
Keep selection on refresh

This is a first try to keep the selection on refreshing the view.

It is missing to keep the expanded unselected sub-tree of a selected node.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh (nightly)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEEDINFO

--- Comment #8 from Felix Schumacher <fe...@internetallee.de> ---
Thanks again for the feedback. Could you re-test the next nightly, if the
performance problem is really gone with the fix?

Date: Tue Jul 25 17:10:55 2017
New Revision: 1802981

URL: http://svn.apache.org/viewvc?rev=1802981&view=rev
Log:
Render the displayed sampler result less often

Bugzilla Id: 60961

Modified:
   
jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35142|0                           |1
        is obsolete|                            |

--- Comment #3 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 35143
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35143&action=edit
Keep selection and expanded state on refresh

This patch keeps the state of selected and expanded elements.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

--- Comment #5 from logox01@gmx.at ---
Hello,

I have successfully retested the issue with the latest jmeter nightly
(r1802306) - everything is working as expected.

Thanks for fixing the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh (nightly)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

--- Comment #7 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 35170
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35170&action=edit
Render the displayed sampler result less often

It would be nice, if the interface ResultRenderer could have been asked for the
currently rendered Object, but this will do probably just fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |60687


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=60687
[Bug 60687] Make GUI more responsive when it gets a lot of events
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh (nightly)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

logox01@gmx.at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEEDINFO                    |RESOLVED

--- Comment #9 from logox01@gmx.at ---
I have successfully re-tested the latest nightly (r1803103).
The performance problem is gone (rendering is now done the first time only).

Thanks for fixing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh (nightly)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

logox01@gmx.at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
           Severity|normal                      |minor
                 OS|                            |All
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to logox01 from comment #0)
> (JMeter 3.2 rc2)
> I have a testplan containing a ViewResultsTree listener and a ThreadGroup
> with HTTPRequests.
> When I run the testplan and select an item in the results tree, this
> selection gets lost as soon as new items show up.

Hello,
I am not sure we can do anything about that without a performance tradeoff.

The idea of recent changes are to allow Load Testing without freezing JMeter.
It is an ANTI-PATTERN but unfortunately a lot of users still do it and this
tends to impact negatively JMeter reputation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

logox01@gmx.at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #6 from logox01@gmx.at ---
I retested the latest nightly and found out, that this change leads to a
massive performance impact, because the rendering for the selected item is done
after every refresh of the results tree.

Eg, if you select a http sample and view the response as html while the test is
running, the html rendering is done again after every refresh of the results
tree (jmeter.gui.refresh_period).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 60961] ViewResultsTree: Selection gets lost after refresh (nightly)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60961
Bug 60961 depends on bug 60687, which changed state.

Bug 60687 Summary: Make GUI more responsive when it gets a lot of events
https://bz.apache.org/bugzilla/show_bug.cgi?id=60687

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.