[GitHub] [incubator-daffodil] tuxji commented on a change in pull request #458: TDML Runner provides namespace. Disallows dup test names.

[GitBox <gi...@apache.org>]

tuxji commented on a change in pull request #458:
URL: https://github.com/apache/incubator-daffodil/pull/458#discussion_r526082659



##########
File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -308,6 +308,9 @@ class DFDLTestSuite private[tdml] (
       case (name, _) =>
         System.err.println("TDML Runner: More than one test case for name '%s'.".format(name))
     }
+    val listOfDups = duplicateTestCases.map{ case(name, _) => name}
+    throw new TDMLExceptionImpl(
+      "More than one test for names: " + listOfDups.mkString(","), None)
   }

Review comment:
       Yes, and it probably looks better to print all the duplicate tests on one line than to print them one by one unless the test names are very long.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org