Using pull requests for reviews

[Szabolcs Vasas <va...@cloudera.com>]

Hi All,

I have used GitHub's pull request feature a couple of times recently and I
found it very convenient so I was wondering if we could start using it for
the Sqoop patches as well instead of Review board. I think submitting and
committing patches is much more simple with pull requests since you do not
have to manually create the patch file and upload it to the JIRA and the
review board.
What do you guys think? Does RB have an advantage over pull request or did
we use it because of historical reasons?

Regards,
Szabolcs

Re: Using pull requests for reviews

[Boglarka Egyed <bo...@cloudera.com>]

Hi Szabolcs,

I think this is pretty natural question.

I did some quick research on the topic and found one limitation with the
pull requests so far: people can not be assigned specifically as reviewers,
however, I don't think this would be a problem as every pull request and
related updates (comments, changes) would be sent to the dev@ mailing list.

From my point of view the most important features of reviewing would be:

   - downloadable patch file
   - commenting on specific line(s)
   - editable description and comments
   - tracked history (including comments and changes)

As far as I see it all of these are available via pull requests too.

To the best of my knowledge Flume also uses pull requests beside using
ReviewBoard for example.

However, it would be nice to see what has driven the community to the
ReviewBoard initially as we could miss something here.

Thanks,
Bogi


On Mon, Jul 24, 2017 at 3:30 PM, Szabolcs Vasas <va...@cloudera.com> wrote:

> Hi All,
>
> I have used GitHub's pull request feature a couple of times recently and I
> found it very convenient so I was wondering if we could start using it for
> the Sqoop patches as well instead of Review board. I think submitting and
> committing patches is much more simple with pull requests since you do not
> have to manually create the patch file and upload it to the JIRA and the
> review board.
> What do you guys think? Does RB have an advantage over pull request or did
> we use it because of historical reasons?
>
> Regards,
> Szabolcs
>