You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/12/02 13:50:11 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #67: Rename classes containing Akka to Pekko
mdedetrich opened a new pull request, #67:
URL: https://github.com/apache/incubator-pekko/pull/67
Renames all Scala/Java classes that happen to contain `Akka` to instead have `Pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jxnu-liguobin commented on a diff in pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
jxnu-liguobin commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#discussion_r1038760946
##########
akka-serialization-jackson/src/main/scala/org/apache/pekko/serialization/jackson/JacksonObjectMapperProvider.scala:
##########
@@ -271,10 +271,10 @@ object JacksonObjectMapperProvider extends ExtensionId[JacksonObjectMapperProvid
private def isModuleEnabled(fqcn: String, dynamicAccess: DynamicAccess): Boolean =
fqcn match {
- case "org.apache.pekko.serialization.jackson.AkkaTypedJacksonModule" =>
+ case "org.apache.pekko.serialization.jackson.PekkoTypedJacksonModule" =>
// akka-actor-typed dependency is "provided" and may not be included
Review Comment:
```suggestion
// pekko-actor-typed dependency is "provided" and may not be included
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jxnu-liguobin commented on a diff in pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
jxnu-liguobin commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#discussion_r1038760565
##########
akka-actor/src/main/scala/org/apache/pekko/PekkoException.scala:
##########
@@ -29,6 +29,6 @@ trait OnlyCauseStackTrace { self: Throwable =>
/**
* This exception is thrown when Akka detects a problem with the provided configuration
Review Comment:
```suggestion
* This exception is thrown when Pekko detects a problem with the provided configuration
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#discussion_r1038745672
##########
akka-actor-tests/src/test/scala/org/apache/pekko/PekkoVersionSpec.scala:
##########
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2009-2022 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko
+
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.wordspec.AnyWordSpec
+
+class PekkoVersionSpec extends AnyWordSpec with Matchers {
+
+ "The Pekko version check" must {
+
+ "succeed if version is ok" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.6")
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.7")
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.6.0")
+ }
+
+ "succeed if version is RC and ok" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.7-RC10")
+ PekkoVersion.require("PekkoVersionSpec", "2.6.0-RC1", "2.6.0-RC1")
+ }
+
+ "fail if version is RC and not ok" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.6-RC1")
+ }
+ }
+
+ "succeed if version is milestone and ok" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.7-M10")
+ }
+
+ "fail if version is milestone and not ok" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.6-M1")
+ }
+ }
+
+ "fail if major version is different" in {
+ // because not bincomp
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "3.0.0")
+ }
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "1.0.0")
+ }
+ }
+
+ "fail if minor version is too low" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.4.19")
+ }
+ }
+
+ "fail if patch version is too low" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.5")
+ }
+ }
+
+ "succeed if current Akka version is SNAPSHOT" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5-SNAPSHOT")
+ }
+
+ "succeed if current Akka version is timestamped SNAPSHOT" in {
Review Comment:
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#issuecomment-1336132882
@jxnu-liguobin So comments/documentation that just has the name Akka will be renamed in another PR (I like to keep things separate incase there are problems). This PR is strictly just about renaming classes that contain the name `Akka` and any comments that are **directly** affected (i.e. if a comment is referring to `SomeAkkaClass`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jxnu-liguobin commented on a diff in pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
jxnu-liguobin commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#discussion_r1038709676
##########
akka-actor-tests/src/test/scala/org/apache/pekko/PekkoVersionSpec.scala:
##########
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2009-2022 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko
+
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.wordspec.AnyWordSpec
+
+class PekkoVersionSpec extends AnyWordSpec with Matchers {
+
+ "The Pekko version check" must {
+
+ "succeed if version is ok" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.6")
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.7")
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.6.0")
+ }
+
+ "succeed if version is RC and ok" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.7-RC10")
+ PekkoVersion.require("PekkoVersionSpec", "2.6.0-RC1", "2.6.0-RC1")
+ }
+
+ "fail if version is RC and not ok" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.6-RC1")
+ }
+ }
+
+ "succeed if version is milestone and ok" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.7-M10")
+ }
+
+ "fail if version is milestone and not ok" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.6-M1")
+ }
+ }
+
+ "fail if major version is different" in {
+ // because not bincomp
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "3.0.0")
+ }
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "1.0.0")
+ }
+ }
+
+ "fail if minor version is too low" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.4.19")
+ }
+ }
+
+ "fail if patch version is too low" in {
+ intercept[UnsupportedPekkoVersion] {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5.5")
+ }
+ }
+
+ "succeed if current Akka version is SNAPSHOT" in {
+ PekkoVersion.require("PekkoVersionSpec", "2.5.6", "2.5-SNAPSHOT")
+ }
+
+ "succeed if current Akka version is timestamped SNAPSHOT" in {
Review Comment:
Pekko version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jxnu-liguobin commented on a diff in pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
jxnu-liguobin commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#discussion_r1038760663
##########
akka-actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##########
@@ -13,7 +13,7 @@ object ForkJoinExecutorConfigurator {
/**
* INTERNAL AKKA USAGE ONLY
Review Comment:
```suggestion
* INTERNAL PEKKO USAGE ONLY
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
mdedetrich merged PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#issuecomment-1335298806
> Could you update https://github.com/apache/incubator-pekko/issues/66 with the fully qualified names of the classes that changed name? Useful for writing a migration script later.
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jxnu-liguobin commented on a diff in pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
jxnu-liguobin commented on code in PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#discussion_r1038760791
##########
akka-actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##########
@@ -13,7 +13,7 @@ object ForkJoinExecutorConfigurator {
/**
* INTERNAL AKKA USAGE ONLY
Review Comment:
There are many `INTERNAL AKKA USAGE ONLY` comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #67: Rename classes containing Akka to Pekko
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #67:
URL: https://github.com/apache/incubator-pekko/pull/67#issuecomment-1336133108
Going to merge the PR, updates to the Akka name in general will be done in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org