You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/12 12:49:33 UTC

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #100: [WIP] started on aiohttp

kezhenxu94 commented on pull request #100:
URL: https://github.com/apache/skywalking-python/pull/100#issuecomment-743751297


   > Test snippet:
   > 
   > ```python
   > from aiohttp import web
   > from skywalking import agent
   > 
   > agent.start()
   > 
   > async def handle(request):
   >     name = request.match_info.get('name', "Anonymous")
   >     text = "Hello, " + name
   >     return web.Response(text=text)
   > 
   > app = web.Application()
   > app.add_routes([web.get('/', handle),
   >                 web.get('/{name}', handle)])
   > 
   > if __name__ == '__main__':
   >     web.run_app(app, port=8000)
   > ```
   > 
   > Am I missing anything to be stored or handled?
   
   I’ll test locally, also, can you please uncomment the PR template so that we can check the items one by one (some may be checked by me though)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org