You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/06/01 03:01:56 UTC
[jira] [Created] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Send back nicer error to clients using outdated IPC version
-----------------------------------------------------------
Key: HADOOP-7346
URL: https://issues.apache.org/jira/browse/HADOOP-7346
Project: Hadoop Common
Issue Type: Improvement
Components: ipc
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Fix For: 0.22.0
When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041963#comment-13041963 ]
Konstantin Boudnik commented on HADOOP-7346:
--------------------------------------------
+1 patch looks good.
Do you think it is possible to test this new behavior with perhaps mocks?
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044081#comment-13044081 ]
Hudson commented on HADOOP-7346:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #637 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/637/])
HADOOP-7346. Send back nicer error message to clients using outdated IPC version. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1131254
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7346:
--------------------------------
Attachment: hadoop-7346.txt
I couldn't think of any way to do it with mocks, so I did brute force and wrote some tests which just replay RPC traces that I captured by hand from 0.18.3, branch-0.20, and 0.21.0. They then verify that the response matches my captured response (which I verified generated a reasonable exception on the client)
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044719#comment-13044719 ]
Todd Lipcon commented on HADOOP-7346:
-------------------------------------
I checked with Nigel, he said he was cool with adding guava as a dependency in 0.22. So I've committed this to 22 as well.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7346:
--------------------------------
Attachment: hadoop-7346.txt
I manually tested this patch using an 0.18.3 client, 0.20.0 client, and CDH3 client (which has the same IPC stack as 0.20.20x series)
I also looped an old client for a few minutes hitting the new server, then took a jstack on the new server, to make sure there weren't any thread leaks.
Unfortunately it's not easy to automatically test it since we can't load old versions of the IPC clients within the context of a unit test.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043224#comment-13043224 ]
Konstantin Boudnik commented on HADOOP-7346:
--------------------------------------------
Creative ;) Thanks.
There's a couple of white-space changes in the latest patch.
+1 otherwise.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044275#comment-13044275 ]
Hudson commented on HADOOP-7346:
--------------------------------
Integrated in Hadoop-Common-trunk #709 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/709/])
HADOOP-7346. Send back nicer error message to clients using outdated IPC version. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1131254
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042544#comment-13042544 ]
Hadoop QA commented on HADOOP-7346:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481179/hadoop-7346.txt
against trunk revision 1129989.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/558//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/558//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/558//console
This message is automatically generated.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044059#comment-13044059 ]
Hadoop QA commented on HADOOP-7346:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481406/hadoop-7346.txt
against trunk revision 1130833.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/573//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/573//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/573//console
This message is automatically generated.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7346:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Thanks for the review, Cos!
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7346:
--------------------------------
Status: Patch Available (was: Open)
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044763#comment-13044763 ]
Hudson commented on HADOOP-7346:
--------------------------------
Integrated in Hadoop-Common-22-branch #62 (See [https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/62/])
HADOOP-7346. Send back nicer error message to clients using outdated IPC version. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132528
Files :
* /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/branches/branch-0.22/ivy/libraries.properties
* /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/branches/branch-0.22/CHANGES.txt
* /hadoop/common/branches/branch-0.22/ivy.xml
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7346:
--------------------------------
Attachment: hadoop-7346.txt
Rebased against trunk and removed spurious whitespace change. I'll commit based on Cos's +1 if this passes Hudson (no code change since previous patch)
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044078#comment-13044078 ]
Todd Lipcon commented on HADOOP-7346:
-------------------------------------
I'd like to commit this to 0.22 branch, since it really helps with version transitions, and I think 0.22 should see more uptake than 0.21 did.
It applies cleanly, the only issue is that it requires guava as a dependency in the tests. Anyone have an issue with my adding it to ivy? The other option is to not include the tests in the commit (or reimplement the two methods we need). Adding guava seems easiest and will also make it easier to backport other patches from trunk which might use it, so that' my preference.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt, hadoop-7346.txt, hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7346) Send back nicer error to clients
using outdated IPC version
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041929#comment-13041929 ]
Hadoop QA commented on HADOOP-7346:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481025/hadoop-7346.txt
against trunk revision 1129905.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/550//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/550//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/550//console
This message is automatically generated.
> Send back nicer error to clients using outdated IPC version
> -----------------------------------------------------------
>
> Key: HADOOP-7346
> URL: https://issues.apache.org/jira/browse/HADOOP-7346
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7346.txt
>
>
> When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException".
> Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira