You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by yaitskov <gi...@git.apache.org> on 2015/11/09 22:25:25 UTC

[GitHub] httpcore pull request: HTTPCORE-412 trailers as Header[] and getEx...

GitHub user yaitskov opened a pull request:

    https://github.com/apache/httpcore/pull/17

    HTTPCORE-412 trailers as Header[] and getExpectedTrailerNames

    getExpectedTrailerNames is introduced in HttpEntity for composing Trailer header.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yaitskov/httpcore trailer-method

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcore/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit f168fa15314de640506e9858f62fa41862b4c5f9
Author: Your Name <yo...@example.com>
Date:   2015-11-09T21:16:57Z

    trailers as Header[] and getExpectedTrailerNames

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcore pull request: HTTPCORE-412 trailers as Header[] and getEx...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the pull request:

    https://github.com/apache/httpcore/pull/17#issuecomment-155397983
  
    DefaultHttpRequestWriter is the wrong place to add headers. This should be done by a protocol interceptor. But I can take from  there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcore pull request: HTTPCORE-412 trailers as Header[] and getEx...

Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the pull request:

    https://github.com/apache/httpcore/pull/17#issuecomment-156049332
  
    Patch with changes committed to SVN trunk
    http://svn.apache.org/viewvc?rev=1713993&view=rev


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] httpcore pull request: HTTPCORE-412 trailers as Header[] and getEx...

Posted by yaitskov <gi...@git.apache.org>.
Github user yaitskov closed the pull request at:

    https://github.com/apache/httpcore/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org