You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "npsables (via GitHub)" <gi...@apache.org> on 2023/02/14 04:11:11 UTC

[GitHub] [airflow] npsables opened a new pull request, #29526: fix: mount kerberos.keytab to worker when enable

npsables opened a new pull request, #29526:
URL: https://github.com/apache/airflow/pull/29526

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   I believe *kerberos.keytab* and others should be mounted to worker container when enabling kerberos. We may want to reuse these files, for example, to spark-submit jobs. Maybe #24369 is a good reference for this pr.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29526:
URL: https://github.com/apache/airflow/pull/29526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454933536

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] npsables commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "npsables (via GitHub)" <gi...@apache.org>.
npsables commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1445916788

   Hi, I added a testcase. Also I notice this function name is misspelled (keberos). Do you want me to change it too?
   https://github.com/apache/airflow/blob/5ad2ed16856ecfc7e96ff1cc1961e22120b8440b/tests/charts/test_kerberos.py#L94


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] npsables commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "npsables (via GitHub)" <gi...@apache.org>.
npsables commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454835831

   All good now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] npsables commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "npsables (via GitHub)" <gi...@apache.org>.
npsables commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1445390663

   Hi sorry for late reply. I observed that my keytab cannot be found (in worker pods) when enabling Kerberos in helm, it doesn't make sense at all. People may want to use it for other services.
   
   If you still think this is a good idea, I can create a testcase (check if **kerberos.keytab** exists after render) for this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454815324

   Static checks need fixing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454933561

   Indeed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1455073353

   Cool. Maybe you would like to take part in this campaign? https://news.apache.org/foundation/entry/the-asf-launches-firstasfcontribution-campaign  - fill-in a short form and the ASF marketing team will contact you if they would like to get more insight :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] npsables commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "npsables (via GitHub)" <gi...@apache.org>.
npsables commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454981046

   This is actually the first time I have contributed to any opensource. It's meaningful to me. Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1445399934

   > If you still think this is a good idea, I can create a testcase (check if **kerberos.keytab** exists after render) for this PR.
   
   Yes. Adding tests is useful to show that. We generally expect all the changes to be covered by tests. So showing tests especially ones that have assertions showing the behaviour you observed (and failing because of that if your change is not implemented) is exactly that is needed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1429088634

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29526:
URL: https://github.com/apache/airflow/pull/29526#issuecomment-1437430976

   Can you please add tests covering that one @npsables ? I think if you add tests, it will be immediately visible what effect it will have. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org