You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/22 18:41:37 UTC

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1109: [HUDI-238] - Migrating to Scala 2.12

vinothchandar commented on a change in pull request #1109: [HUDI-238] - Migrating to Scala 2.12
URL: https://github.com/apache/incubator-hudi/pull/1109#discussion_r360719394
 
 

 ##########
 File path: hudi-cli/pom.xml
 ##########
 @@ -158,11 +158,11 @@
     <!-- Spark -->
     <dependency>
       <groupId>org.apache.spark</groupId>
-      <artifactId>spark-core_2.11</artifactId>
+      <artifactId>spark-core_2.12</artifactId>
     </dependency>
     <dependency>
       <groupId>org.apache.spark</groupId>
-      <artifactId>spark-sql_2.11</artifactId>
+      <artifactId>spark-sql_2.12</artifactId>
 
 Review comment:
   would it be better pull the scala version into variable in the parent pom and then use it everywhere. This way someone can also force a `2.11` build if needed.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services