You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/14 00:01:17 UTC

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.

bharatviswa504 opened a new pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.
URL: https://github.com/apache/hadoop-ozone/pull/816
 
 
   ## What changes were proposed in this pull request?
   
   Removed initialization of doubleBuffer when ratis is enabled in OzoneManagerProtocolServerSideTranslatorPB.java. As doubleBuffer is only needed in StateMachine when ratis is enabled.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3381
   
   ## How was this patch tested?
   
   Existing tests should cover this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] mukul1987 commented on a change in pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.

Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.
URL: https://github.com/apache/hadoop-ozone/pull/816#discussion_r407884806
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
 ##########
 @@ -106,6 +106,12 @@
   private final OzoneManager impl;
   private OzoneManagerDoubleBuffer ozoneManagerDoubleBuffer;
 
+
+  public OzoneManagerRequestHandler(OzoneManager om) {
 
 Review comment:
   Should the isRatisEnabled flag passed here and then we should assign the ozoneManagerDoubleBuffer using a getter in the OzoneManagerProtocolServerSideTranslatorPB.java ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.
URL: https://github.com/apache/hadoop-ozone/pull/816#discussion_r408247111
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
 ##########
 @@ -106,6 +106,12 @@
   private final OzoneManager impl;
   private OzoneManagerDoubleBuffer ozoneManagerDoubleBuffer;
 
+
+  public OzoneManagerRequestHandler(OzoneManager om) {
 
 Review comment:
   I think end result will be the same. If you want that way I can change it? Any advantage with that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #816: HDDS-3381. OzoneManager starts 2 OzoneManagerDoubleBuffer for HA cluster.
URL: https://github.com/apache/hadoop-ozone/pull/816#discussion_r408247111
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
 ##########
 @@ -106,6 +106,12 @@
   private final OzoneManager impl;
   private OzoneManagerDoubleBuffer ozoneManagerDoubleBuffer;
 
+
+  public OzoneManagerRequestHandler(OzoneManager om) {
 
 Review comment:
   I think end result will be the same in non-ratis enabled ozoneManagerDoubleBuffer will be null, and the same will be assigned in OzoneManagerProtocolServerSideTranslatorPB. If you want that way I can change it? Any advantage with that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org