[GitHub] mistercrunch commented on a change in pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4880: Adding X and Y axis Formats to the Bubble Chart Tooltip 
URL: https://github.com/apache/incubator-superset/pull/4880#discussion_r185869626
 
 

 ##########
 File path: superset/assets/src/visualizations/nvd3_vis.js
 ##########
 @@ -351,6 +352,7 @@ export default function nvd3Vis(slice, payload) {
         chart.showLegend(false);
       } else {
         chart.showLegend(fd.show_legend);
+        chart.legend.margin({ top: 5, right: 30, left: 80, bottom: 30 });
 
 Review comment:
   Should `bottom: 30` be different when the bar values are not shown? What was the original value? We're trying to make the most out of the real estate, `30` pixels is significant when the chart is displayed small in a dashboard...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org