[GitHub] [solr] dsmiley commented on a change in pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #369:
URL: https://github.com/apache/solr/pull/369#discussion_r737406938



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClusterStateProvider.java
##########
@@ -22,6 +22,9 @@
 import org.apache.http.client.HttpClient;
 import org.apache.solr.client.solrj.SolrClient;
 
+/**
+ * Retrieves cluster state via from Solr REST APIs

Review comment:
       It's an abuse of the word REST here.  `?action=CLUSTERSTATUS` is not RESTful.  Yes, this is an old debate but I'm old enough to have lived through this :-). Please don't add REST here; I suggest "Solr HTTP APIs".  Some parts of Solr, however, it's a reasonable characterization.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org