You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2023/05/09 03:11:28 UTC
[GitHub] [druid] kfaraz opened a new pull request, #14230: Add tests for CostBalancerStrategy
kfaraz opened a new pull request, #14230:
URL: https://github.com/apache/druid/pull/14230
### Changes
- Add better tests for `CostBalancerStrategy` which verify the computed cost values for different granularities.
- Add tests to demonstrate that after a long enough period, all costs become negligible
### Excluded
Tests that verify the server chosen for a given operation, such as load, drop or move are better suited to `BalancingStrategiesTest`, as we would want to verify that behaviour for all existing strategies. Some of these tests already exist and more can be added later.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz merged pull request #14230: Add tests for CostBalancerStrategy
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #14230:
URL: https://github.com/apache/druid/pull/14230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #14230: Add tests for CostBalancerStrategy
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #14230:
URL: https://github.com/apache/druid/pull/14230#issuecomment-1567707017
Thanks for the review, @AmatyaAvadhanula !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org