You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/23 08:49:55 UTC
[GitHub] ShannonDing commented on a change in pull request #39: [ISSUE
#38]support payload with byte[] type in message conversion
ShannonDing commented on a change in pull request #39: [ISSUE #38]support payload with byte[] type in message conversion
URL: https://github.com/apache/rocketmq-spring/pull/39#discussion_r250100080
##########
File path: rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/RocketMQUtil.java
##########
@@ -114,6 +114,8 @@ public static MessagingException convert(MQClientException e) {
if (payloadObj instanceof String) {
payloads = ((String) payloadObj).getBytes(Charset.forName(charset));
+ } else if (message.getPayload() instanceof byte[]) {
Review comment:
It is better, IMO, to keep the code style same as line 115.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services